Skip to content

Commit 5fd1585

Browse files
bnoordhuisFishrock123
authored andcommitted
src: fix readability/inheritance cpplint warnings
PR-URL: #7462 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
1 parent b7e006b commit 5fd1585

File tree

6 files changed

+12
-15
lines changed

6 files changed

+12
-15
lines changed

src/async-wrap.cc

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,11 @@ class RetainedAsyncInfo: public RetainedObjectInfo {
3838
public:
3939
explicit RetainedAsyncInfo(uint16_t class_id, AsyncWrap* wrap);
4040

41-
virtual void Dispose() override;
42-
virtual bool IsEquivalent(RetainedObjectInfo* other) override;
43-
virtual intptr_t GetHash() override;
44-
virtual const char* GetLabel() override;
45-
virtual intptr_t GetSizeInBytes() override;
41+
void Dispose() override;
42+
bool IsEquivalent(RetainedObjectInfo* other) override;
43+
intptr_t GetHash() override;
44+
const char* GetLabel() override;
45+
intptr_t GetSizeInBytes() override;
4646

4747
private:
4848
const char* label_;

src/cares_wrap.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ class QueryWrap : public AsyncWrap {
257257
req_wrap_obj->Set(env->domain_string(), env->domain_array()->Get(0));
258258
}
259259

260-
virtual ~QueryWrap() override {
260+
~QueryWrap() override {
261261
CHECK_EQ(false, persistent().IsEmpty());
262262
ClearWrap(object());
263263
persistent().Reset();

src/fs_event_wrap.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ class FSEventWrap: public HandleWrap {
3535

3636
private:
3737
FSEventWrap(Environment* env, Local<Object> object);
38-
virtual ~FSEventWrap() override;
38+
~FSEventWrap() override;
3939

4040
static void OnEvent(uv_fs_event_t* handle, const char* filename, int events,
4141
int status);

src/handle_wrap.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ class HandleWrap : public AsyncWrap {
5555
uv_handle_t* handle,
5656
AsyncWrap::ProviderType provider,
5757
AsyncWrap* parent = nullptr);
58-
virtual ~HandleWrap() override;
58+
~HandleWrap() override;
5959

6060
private:
6161
friend class Environment;

src/inspector_agent.cc

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -240,18 +240,15 @@ class ChannelImpl final : public blink::protocol::FrontendChannel {
240240
explicit ChannelImpl(AgentImpl* agent): agent_(agent) {}
241241
virtual ~ChannelImpl() {}
242242
private:
243-
virtual void sendProtocolResponse(int callId,
244-
const String16& message)
245-
override {
243+
void sendProtocolResponse(int callId, const String16& message) override {
246244
sendMessageToFrontend(message);
247245
}
248246

249-
virtual void sendProtocolNotification(
250-
const String16& message) override {
247+
void sendProtocolNotification(const String16& message) override {
251248
sendMessageToFrontend(message);
252249
}
253250

254-
virtual void flushProtocolNotifications() override { }
251+
void flushProtocolNotifications() override { }
255252

256253
void sendMessageToFrontend(const String16& message) {
257254
agent_->Write(message.utf8());

src/node_stat_watcher.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ namespace node {
1313

1414
class StatWatcher : public AsyncWrap {
1515
public:
16-
virtual ~StatWatcher() override;
16+
~StatWatcher() override;
1717

1818
static void Initialize(Environment* env, v8::Local<v8::Object> target);
1919

0 commit comments

Comments
 (0)