Skip to content

Commit 5c71ea1

Browse files
committed
deps: V8: cherry-pick fbb28902e049
Original commit message: Update V8 postmortem metadata script This commit updates the gen-postmortem-metadata.py script to incorporate changes in V8 8.4. This removes the need to float a patch to the script in Node.js. Change-Id: I69da40e792f22748b0eee2952b9009b2f03d13f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565275 Reviewed-by: Joyee Cheung <joyee@igalia.com> Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/master@{#71646} Refs: v8/v8@fbb2890 PR-URL: #36139 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>
1 parent 5c4be11 commit 5c71ea1

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.11',
39+
'v8_embedder_string': '-node.12',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/tools/gen-postmortem-metadata.py

+1
Original file line numberDiff line numberDiff line change
@@ -287,6 +287,7 @@
287287
'SlicedString, offset, SMI, kOffsetOffset',
288288
'ThinString, actual, String, kActualOffset',
289289
'Symbol, name, Object, kDescriptionOffset',
290+
'FixedArrayBase, length, SMI, kLengthOffset',
290291
];
291292

292293
#

0 commit comments

Comments
 (0)