Skip to content

Commit 5c397d9

Browse files
committed
fixup! net,stream: remove DuplexBase
1 parent 82b72c8 commit 5c397d9

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

lib/_stream_duplex.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ const Writable = require('_stream_writable');
3535
util.inherits(Duplex, Readable);
3636

3737
{
38-
// avoid scope creep, the keys array can then be collected
38+
// Allow the keys array to be GC'ed.
3939
const keys = Object.keys(Writable.prototype);
4040
for (var v = 0; v < keys.length; v++) {
4141
const method = keys[v];

lib/net.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ function Socket(options) {
244244
else
245245
options = util._extend({}, options);
246246

247-
const aho = options.allowHalfOpen;
247+
const allowHalfOpen = options.allowHalfOpen;
248248

249249
// Prevent the "no-half-open enforcer" from being inherited from `Duplex`.
250250
options.allowHalfOpen = true;
@@ -253,7 +253,7 @@ function Socket(options) {
253253
stream.Duplex.call(this, options);
254254

255255
// Default to *not* allowing half open sockets.
256-
this.allowHalfOpen = Boolean(aho);
256+
this.allowHalfOpen = Boolean(allowHalfOpen);
257257

258258
if (options.handle) {
259259
this._handle = options.handle; // private

0 commit comments

Comments
 (0)