Skip to content

Commit 5bcbcdd

Browse files
committed
tools: refactor version update
1 parent b876e35 commit 5bcbcdd

19 files changed

+74
-125
lines changed

tools/dep_updaters/update-acorn.sh

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@ ROOT=$(cd "$(dirname "$0")/../.." && pwd)
1212
[ -x "$NODE" ] || NODE=$(command -v node)
1313
NPM="$ROOT/deps/npm/bin/npm-cli.js"
1414

15-
# Source the dependencies updater utils
16-
. "$ROOT/tools/dep_updaters/utils.sh"
17-
1815
NEW_VERSION=$("$NODE" "$NPM" view acorn dist-tags.latest)
1916
CURRENT_VERSION=$("$NODE" -p "require('./deps/acorn/acorn/package.json').version")
2017

@@ -52,8 +49,10 @@ mv acorn-tmp/node_modules/acorn deps/acorn
5249

5350
rm -rf acorn-tmp/
5451

55-
# Update the version number on doc/contributing/maintaining/maintaining-dependencies.md
56-
update_dependency_version "acorn" $NEW_VERSION
52+
# Update the version number
53+
# shellcheck disable=SC1091
54+
. "$ROOT/tools/dep_updaters/utils.sh"
55+
update_dependency_version "acorn" "$NEW_VERSION"
5756

5857
echo "All done!"
5958
echo ""

tools/dep_updaters/update-ada.sh

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -52,13 +52,10 @@ mv "$DEPS_DIR/ada/"*.gyp "$DEPS_DIR/ada/README.md" "$WORKSPACE/"
5252
rm -rf "$DEPS_DIR/ada"
5353
mv "$WORKSPACE" "$DEPS_DIR/ada"
5454

55-
# update the version number on doc/contributing/maintaining/maintaining-dependencies.md
56-
DEPS_FILE_PATH="$BASE_DIR/doc/contributing/maintaining/maintaining-dependencies.md"
57-
PACKAGE_NAME="ada"
58-
VERSION_NO_DOTS=$(echo $NEW_VERSION | sed -e 's/\.//g') # remove version dots for anchor markdown
59-
perl -i -pe 's|^\* \['$PACKAGE_NAME'.*|* ['$PACKAGE_NAME' '$NEW_VERSION'][]|' $DEPS_FILE_PATH
60-
perl -i -pe 's|^\['$PACKAGE_NAME'.*\]: #'$PACKAGE_NAME'.*|['$PACKAGE_NAME' '$NEW_VERSION']: #'$PACKAGE_NAME'-'$VERSION_NO_DOTS'|' $DEPS_FILE_PATH
61-
perl -i -pe 's|^### '$PACKAGE_NAME'.*|### '$PACKAGE_NAME' '$NEW_VERSION'|' $DEPS_FILE_PATH
55+
# Update the version number
56+
# shellcheck disable=SC1091
57+
. "$BASE_DIR/tools/dep_updaters/utils.sh"
58+
update_dependency_version "ada" "$NEW_VERSION"
6259

6360
echo "All done!"
6461
echo ""

tools/dep_updaters/update-base64.sh

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -51,13 +51,10 @@ mv "$WORKSPACE/base64" "$DEPS_DIR/base64/"
5151
# to work, we create it and leave it empty.
5252
echo "// Intentionally empty" >> "$DEPS_DIR/base64/base64/lib/config.h"
5353

54-
# update the version number on doc/contributing/maintaining/maintaining-dependencies.md
55-
DEPS_FILE_PATH="$BASE_DIR/doc/contributing/maintaining/maintaining-dependencies.md"
56-
PACKAGE_NAME="base64"
57-
VERSION_NO_DOTS=$(echo $NEW_VERSION | sed -e 's/\.//g') # remove version dots for anchor markdown
58-
perl -i -pe 's|^\* \['$PACKAGE_NAME'.*|* ['$PACKAGE_NAME' '$NEW_VERSION'][]|' $DEPS_FILE_PATH
59-
perl -i -pe 's|^\['$PACKAGE_NAME'.*\]: #'$PACKAGE_NAME'.*|['$PACKAGE_NAME' '$NEW_VERSION']: #'$PACKAGE_NAME'-'$VERSION_NO_DOTS'|' $DEPS_FILE_PATH
60-
perl -i -pe 's|^### '$PACKAGE_NAME'.*|### '$PACKAGE_NAME' '$NEW_VERSION'|' $DEPS_FILE_PATH
54+
# Update the version number
55+
# shellcheck disable=SC1091
56+
. "$BASE_DIR/tools/dep_updaters/utils.sh"
57+
update_dependency_version "base64" "$NEW_VERSION"
6158

6259
echo "All done!"
6360
echo ""

tools/dep_updaters/update-brotli.sh

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -62,13 +62,10 @@ mkdir "$DEPS_DIR/brotli"
6262
echo "Update c and LICENSE"
6363
mv "$WORKSPACE/brotli/c" "$WORKSPACE/brotli/LICENSE" "$WORKSPACE/brotli/brotli.gyp" "$DEPS_DIR/brotli"
6464

65-
# update the version number on doc/contributing/maintaining/maintaining-dependencies.md
66-
DEPS_FILE_PATH="$BASE_DIR/doc/contributing/maintaining/maintaining-dependencies.md"
67-
PACKAGE_NAME="brotli"
68-
VERSION_NO_DOTS=$(echo $NEW_VERSION | sed -e 's/\.//g') # remove version dots for anchor markdown
69-
perl -i -pe 's|^\* \['$PACKAGE_NAME'.*|* ['$PACKAGE_NAME' '$NEW_VERSION'][]|' $DEPS_FILE_PATH
70-
perl -i -pe 's|^\['$PACKAGE_NAME'.*\]: #'$PACKAGE_NAME'.*|['$PACKAGE_NAME' '$NEW_VERSION']: #'$PACKAGE_NAME'-'$VERSION_NO_DOTS'|' $DEPS_FILE_PATH
71-
perl -i -pe 's|^### '$PACKAGE_NAME'.*|### '$PACKAGE_NAME' '$NEW_VERSION'|' $DEPS_FILE_PATH
65+
# Update the version number
66+
# shellcheck disable=SC1091
67+
. "$BASE_DIR/tools/dep_updaters/utils.sh"
68+
update_dependency_version "brotli" "$NEW_VERSION"
7269

7370
echo "All done!"
7471
echo ""

tools/dep_updaters/update-c-ares.sh

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -58,13 +58,10 @@ echo "Replacing existing c-ares"
5858
rm -rf "$DEPS_DIR/cares"
5959
mv "$WORKSPACE/cares" "$DEPS_DIR/"
6060

61-
# update the version number on doc/contributing/maintaining/maintaining-dependencies.md
62-
DEPS_FILE_PATH="$BASE_DIR/doc/contributing/maintaining/maintaining-dependencies.md"
63-
PACKAGE_NAME="c-ares"
64-
VERSION_NO_DOTS=$(echo $NEW_VERSION | sed -e 's/\.//g') # remove version dots for anchor markdown
65-
perl -i -pe 's|^\* \['$PACKAGE_NAME'.*|* ['$PACKAGE_NAME' '$NEW_VERSION'][]|' $DEPS_FILE_PATH
66-
perl -i -pe 's|^\['$PACKAGE_NAME'.*\]: #'$PACKAGE_NAME'.*|['$PACKAGE_NAME' '$NEW_VERSION']: #'$PACKAGE_NAME'-'$VERSION_NO_DOTS'|' $DEPS_FILE_PATH
67-
perl -i -pe 's|^### '$PACKAGE_NAME'.*|### '$PACKAGE_NAME' '$NEW_VERSION'|' $DEPS_FILE_PATH
61+
# Update the version number
62+
# shellcheck disable=SC1091
63+
. "$BASE_DIR/tools/dep_updaters/utils.sh"
64+
update_dependency_version "c-ares" "$NEW_VERSION"
6865

6966
echo "All done!"
7067
echo ""

tools/dep_updaters/update-cjs-module-lexer.sh

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -50,13 +50,10 @@ rm -rf "$DEPS_DIR/cjs-module-lexer"
5050

5151
mv node_modules/cjs-module-lexer "$DEPS_DIR/cjs-module-lexer"
5252

53-
# update the version number on doc/contributing/maintaining/maintaining-dependencies.md
54-
DEPS_FILE_PATH="$BASE_DIR/doc/contributing/maintaining/maintaining-dependencies.md"
55-
PACKAGE_NAME="cjs-module-lexer"
56-
VERSION_NO_DOTS=$(echo $NEW_VERSION | sed -e 's/\.//g') # remove version dots for anchor markdown
57-
perl -i -pe 's|^\* \['$PACKAGE_NAME'.*|* ['$PACKAGE_NAME' '$NEW_VERSION'][]|' $DEPS_FILE_PATH
58-
perl -i -pe 's|^\['$PACKAGE_NAME'.*\]: #'$PACKAGE_NAME'.*|['$PACKAGE_NAME' '$NEW_VERSION']: #'$PACKAGE_NAME'-'$VERSION_NO_DOTS'|' $DEPS_FILE_PATH
59-
perl -i -pe 's|^### '$PACKAGE_NAME'.*|### '$PACKAGE_NAME' '$NEW_VERSION'|' $DEPS_FILE_PATH
53+
# Update the version number
54+
# shellcheck disable=SC1091
55+
. "$BASE_DIR/tools/dep_updaters/utils.sh"
56+
update_dependency_version "cjs-module-lexer" "$NEW_VERSION"
6057

6158
echo "All done!"
6259
echo ""

tools/dep_updaters/update-googletest.sh

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -80,12 +80,10 @@ NEW_GYP=$(
8080

8181
echo "$NEW_GYP" >"$DEPS_DIR/googletest/googletest.gyp"
8282

83-
# update the version number on doc/contributing/maintaining/maintaining-dependencies.md
84-
DEPS_FILE_PATH="$BASE_DIR/doc/contributing/maintaining/maintaining-dependencies.md"
85-
PACKAGE_NAME="googletest"
86-
perl -i -pe 's|^\* \['$PACKAGE_NAME'.*|* ['$PACKAGE_NAME' '$NEW_VERSION'][]|' $DEPS_FILE_PATH
87-
perl -i -pe 's|^\['$PACKAGE_NAME'.*\]: #'$PACKAGE_NAME'.*|['$PACKAGE_NAME' '$NEW_VERSION']: #'$PACKAGE_NAME'-'$NEW_VERSION'|' $DEPS_FILE_PATH
88-
perl -i -pe 's|^### '$PACKAGE_NAME'.*|### '$PACKAGE_NAME' ['$NEW_VERSION'](https://github.com/google/googletest/commit/'$NEW_VERSION')|' $DEPS_FILE_PATH
83+
# Update the version number
84+
# shellcheck disable=SC1091
85+
. "$BASE_DIR/tools/dep_updaters/utils.sh"
86+
update_dependency_version "googletest" "$NEW_VERSION"
8987

9088
echo "All done!"
9189
echo ""

tools/dep_updaters/update-icu.sh

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -61,13 +61,10 @@ sed -i '' -e "s|\"md5\": \"\(.*\)\".*|\"md5\": \"$CHECKSUM\"|" "$TOOLS_DIR/icu/c
6161

6262
rm -rf out "$DEPS_DIR/icu" "$DEPS_DIR/icu4c*"
6363

64-
# update the version number on doc/contributing/maintaining/maintaining-dependencies.md
65-
DEPS_FILE_PATH="$BASE_DIR/doc/contributing/maintaining/maintaining-dependencies.md"
66-
PACKAGE_NAME="icu-small"
67-
VERSION_NO_DOTS=$(echo $NEW_VERSION | sed -e 's/\.//g') # remove version dots for anchor markdown
68-
perl -i -pe 's|^\* \['$PACKAGE_NAME'.*|* ['$PACKAGE_NAME' '$NEW_VERSION'][]|' $DEPS_FILE_PATH
69-
perl -i -pe 's|^\['$PACKAGE_NAME'.*\]: #'$PACKAGE_NAME'.*|['$PACKAGE_NAME' '$NEW_VERSION']: #'$PACKAGE_NAME'-'$VERSION_NO_DOTS'|' $DEPS_FILE_PATH
70-
perl -i -pe 's|^### '$PACKAGE_NAME'.*|### '$PACKAGE_NAME' '$NEW_VERSION'|' $DEPS_FILE_PATH
64+
# Update the version number
65+
# shellcheck disable=SC1091
66+
. "$BASE_DIR/tools/dep_updaters/utils.sh"
67+
update_dependency_version "icu-small" "$NEW_VERSION"
7168

7269
echo "All done!"
7370
echo ""

tools/dep_updaters/update-libuv.sh

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -52,13 +52,10 @@ mv "$DEPS_DIR/uv/"*.gyp "$DEPS_DIR/uv/"*.gypi "$WORKSPACE/uv/"
5252
rm -rf "$DEPS_DIR/uv"
5353
mv "$WORKSPACE/uv" "$DEPS_DIR/"
5454

55-
# update the version number on doc/contributing/maintaining/maintaining-dependencies.md
56-
DEPS_FILE_PATH="$BASE_DIR/doc/contributing/maintaining/maintaining-dependencies.md"
57-
PACKAGE_NAME="libuv"
58-
VERSION_NO_DOTS=$(echo $NEW_VERSION | sed -e 's/\.//g') # remove version dots for anchor markdown
59-
perl -i -pe 's|^\* \['$PACKAGE_NAME'.*|* ['$PACKAGE_NAME' '$NEW_VERSION'][]|' $DEPS_FILE_PATH
60-
perl -i -pe 's|^\['$PACKAGE_NAME'.*\]: #'$PACKAGE_NAME'.*|['$PACKAGE_NAME' '$NEW_VERSION']: #'$PACKAGE_NAME'-'$VERSION_NO_DOTS'|' $DEPS_FILE_PATH
61-
perl -i -pe 's|^### '$PACKAGE_NAME'.*|### '$PACKAGE_NAME' '$NEW_VERSION'|' $DEPS_FILE_PATH
55+
# Update the version number
56+
# shellcheck disable=SC1091
57+
. "$BASE_DIR/tools/dep_updaters/utils.sh"
58+
update_dependency_version "libuv" "$NEW_VERSION"
6259

6360
echo "All done!"
6461
echo ""

tools/dep_updaters/update-llhttp.sh

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -69,13 +69,10 @@ else
6969
cp -a "llhttp-release-v$NEW_VERSION" "$DEPS_DIR/llhttp"
7070
fi
7171

72-
# update the version number on doc/contributing/maintaining/maintaining-dependencies.md
73-
DEPS_FILE_PATH="$BASE_DIR/doc/contributing/maintaining/maintaining-dependencies.md"
74-
PACKAGE_NAME="llhttp"
75-
VERSION_NO_DOTS=$(echo $NEW_VERSION | sed -e 's/\.//g') # remove version dots for anchor markdown
76-
perl -i -pe 's|^\* \['$PACKAGE_NAME'.*|* ['$PACKAGE_NAME' '$NEW_VERSION'][]|' $DEPS_FILE_PATH
77-
perl -i -pe 's|^\['$PACKAGE_NAME'.*\]: #'$PACKAGE_NAME'.*|['$PACKAGE_NAME' '$NEW_VERSION']: #'$PACKAGE_NAME'-'$VERSION_NO_DOTS'|' $DEPS_FILE_PATH
78-
perl -i -pe 's|^### '$PACKAGE_NAME'.*|### '$PACKAGE_NAME' '$NEW_VERSION'|' $DEPS_FILE_PATH
72+
# Update the version number
73+
# shellcheck disable=SC1091
74+
. "$BASE_DIR/tools/dep_updaters/utils.sh"
75+
update_dependency_version "llhttp" "$NEW_VERSION"
7976

8077
echo ""
8178
echo "All done!"

0 commit comments

Comments
 (0)