diff --git a/common.gypi b/common.gypi index 9c5efa905dfd3c..dd4f91484c9148 100644 --- a/common.gypi +++ b/common.gypi @@ -38,7 +38,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.7', + 'v8_embedder_string': '-node.8', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/include/v8.h b/deps/v8/include/v8.h index 9b7be9fb93068e..01fb56b55db193 100644 --- a/deps/v8/include/v8.h +++ b/deps/v8/include/v8.h @@ -2631,8 +2631,7 @@ class V8_EXPORT String : public Name { public: virtual ~ExternalStringResourceBase() = default; - V8_DEPRECATE_SOON("Use IsCacheable().", - virtual bool IsCompressible() const) { + V8_DEPRECATED("Use IsCacheable().", virtual bool IsCompressible() const) { return false; } @@ -2641,16 +2640,7 @@ class V8_EXPORT String : public Name { * ExternalStringResource::data() may be cached, otherwise it is not * expected to be stable beyond the current top-level task. */ - virtual bool IsCacheable() const { -#if __clang__ -#pragma clang diagnostic push -#pragma clang diagnostic ignored "-Wdeprecated-declarations" -#endif - return !IsCompressible(); -#if __clang__ -#pragma clang diagnostic pop -#endif - } + virtual bool IsCacheable() const { return true; } protected: ExternalStringResourceBase() = default;