src: provide faster string character counts

nodejs · Feb 2, 2023 · 58ce8e9 · 58ce8e9
1 parent f84de0a
commit 58ce8e9
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/inspector/node_string.cc b/src/inspector/node_string.cc
@@ -1,5 +1,6 @@
 #include "node_string.h"
 #include "node/inspector/protocol/Protocol.h"
+#include "simdutf.h"
 
 #include <unicode/unistr.h>
 
@@ -118,9 +119,8 @@ const uint8_t* CharactersUTF8(const String& s) {
 }
 
 size_t CharacterCount(const String& s) {
-  icu::UnicodeString utf16 =
-      icu::UnicodeString::fromUTF8(icu::StringPiece(s.data(), s.length()));
-  return utf16.countChar32();
+  // TODO: Add a test to validate CharacterCount returns correct value.
+  return simdutf::utf32_length_from_utf8(s.data(), s.length());
 }
 
 }  // namespace StringUtil