Skip to content

Commit

Permalink
test: rename process.argv[0] to process.execPath, rename ex to err
Browse files Browse the repository at this point in the history
PR-URL: #23488
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
kaltepeter authored and MylesBorins committed Oct 30, 2018
1 parent 7e56801 commit 58aaa61
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test/parallel/test-common.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ const { execFile } = require('child_process');
// test for leaked global detection
{
const p = fixtures.path('leakedGlobal.js');
execFile(process.argv[0], [p], common.mustCall((ex, stdout, stderr) => {
assert.notStrictEqual(ex.code, 0);
execFile(process.execPath, [p], common.mustCall((err, stdout, stderr) => {
assert.notStrictEqual(err.code, 0);
assert.ok(/\bAssertionError\b.*\bUnexpected global\b.*\bgc\b/.test(stderr));
}));
}
Expand Down Expand Up @@ -85,8 +85,8 @@ const failFixtures = [
];
for (const p of failFixtures) {
const [file, expected] = p;
execFile(process.argv[0], [file], common.mustCall((ex, stdout, stderr) => {
assert.ok(ex);
execFile(process.execPath, [file], common.mustCall((err, stdout, stderr) => {
assert.ok(err);
assert.strictEqual(stderr, '');
const firstLine = stdout.split('\n').shift();
assert.strictEqual(firstLine, expected);
Expand Down

0 comments on commit 58aaa61

Please sign in to comment.