Skip to content

Commit

Permalink
build: use BUILDTYPE when building V8 in Makefile
Browse files Browse the repository at this point in the history
Without this it would always compile Release and Debug builds.

Ref: #7477
PR-URL: #7482
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
targos authored and Myles Borins committed Jul 12, 2016
1 parent de5d718 commit 5841332
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ cctest: all

v8:
tools/make-v8.sh v8
$(MAKE) -C deps/v8 $(V8_ARCH) $(V8_BUILD_OPTIONS)
$(MAKE) -C deps/v8 $(V8_ARCH).$(BUILDTYPE_LOWER) $(V8_BUILD_OPTIONS)

test: | cctest # Depends on 'all'.
$(PYTHON) tools/test.py --mode=release doctool message pseudo-tty parallel sequential -J
Expand Down

0 comments on commit 5841332

Please sign in to comment.