src: close tracing event loop

Clean up resources when tearing down the tracing agent. PR-URL: #21867 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
nodejs · Aug 1, 2018 · 56edd5f · 56edd5f
1 parent 4c9c1bb
commit 56edd5f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/tracing/agent.cc b/src/tracing/agent.cc
@@ -2,6 +2,8 @@
 
 #include <string>
 #include "tracing/node_trace_buffer.h"
+#include "debug_utils.h"
+#include "env-inl.h"
 
 namespace node {
 namespace tracing {
@@ -53,6 +55,10 @@ Agent::Agent() {
   CHECK_EQ(uv_loop_init(&tracing_loop_), 0);
 }
 
+Agent::~Agent() {
+  CheckedUvLoopClose(&tracing_loop_);
+}
+
 void Agent::Start() {
   if (started_)
     return;

diff --git a/src/tracing/agent.h b/src/tracing/agent.h
@@ -64,6 +64,7 @@ class AgentWriterHandle {
 class Agent {
  public:
   Agent();
+  ~Agent();
 
   TracingController* GetTracingController() { return tracing_controller_; }