Skip to content

Commit 5581681

Browse files
committed
test: remove timers from test-tls-socket-close
Fixes: #49902
1 parent 6a2d6df commit 5581681

File tree

1 file changed

+17
-14
lines changed

1 file changed

+17
-14
lines changed

test/parallel/test-tls-socket-close.js

Lines changed: 17 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,10 @@ const cert = fixtures.readKey('agent2-cert.pem');
1515
let serverTlsSocket;
1616
const tlsServer = tls.createServer({ cert, key }, (socket) => {
1717
serverTlsSocket = socket;
18+
socket.on('data', (chunk) => {
19+
assert.strictEqual(chunk[0], 46);
20+
socket.write('.');
21+
});
1822
socket.on('close', dec);
1923
});
2024

@@ -45,24 +49,23 @@ function connectClient(server) {
4549
rejectUnauthorized: false
4650
});
4751

48-
clientTlsSocket.write('foo', 'utf8', common.mustCall(() => {
49-
assert(netSocket);
50-
netSocket.setTimeout(common.platformTimeout(10), common.mustCall(() => {
51-
assert(serverTlsSocket);
52+
clientTlsSocket.write('.');
53+
54+
clientTlsSocket.on('data', (chunk) => {
55+
assert.strictEqual(chunk[0], 46);
5256

53-
netSocket.destroy();
54-
assert.strictEqual(netSocket.destroyed, true);
57+
netSocket.destroy();
58+
assert.strictEqual(netSocket.destroyed, true);
5559

60+
setImmediate(() => {
61+
// Close callbacks are executed after `setImmediate()` callbacks.
62+
assert.strictEqual(netSocketCloseEmitted, false);
63+
assert.strictEqual(serverTlsSocket.destroyed, false);
5664
setImmediate(() => {
57-
// Close callbacks are executed after `setImmediate()` callbacks.
58-
assert.strictEqual(netSocketCloseEmitted, false);
59-
assert.strictEqual(serverTlsSocket.destroyed, false);
60-
setImmediate(() => {
61-
assert.strictEqual(netSocketCloseEmitted, true);
62-
});
65+
assert.strictEqual(netSocketCloseEmitted, true);
6366
});
64-
}));
65-
}));
67+
});
68+
});
6669

6770
clientTlsSocket.on('close', dec);
6871
}

0 commit comments

Comments
 (0)