Skip to content

Commit 535859d

Browse files
committed
tools: update gyp-next to v0.2.1
PR-URL: #32698 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
1 parent a8f5917 commit 535859d

File tree

4 files changed

+30
-3
lines changed

4 files changed

+30
-3
lines changed
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
name: Node.js Windows integration
2+
3+
on: [push, pull_request]
4+
5+
jobs:
6+
build-windows:
7+
runs-on: windows-latest
8+
steps:
9+
- name: Clone node-gyp
10+
uses: actions/checkout@v2
11+
with:
12+
path: gyp-next
13+
- name: Clone nodejs/node
14+
uses: actions/checkout@v2
15+
with:
16+
repository: nodejs/node
17+
path: node
18+
- name: Install deps
19+
run: choco install nasm
20+
- name: Replace gyp in Node.js
21+
run: |
22+
rm -Recurse node/tools/gyp
23+
cp -Recurse gyp-next node/tools/gyp
24+
- name: Build Node.js
25+
run: |
26+
cd node
27+
./vcbuild.bat

tools/gyp/LICENSE

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
Copyright (c) 2019 Ujjwal Sharma. All rights reserved.
1+
Copyright (c) 2020 Node.js contributors. All rights reserved.
22
Copyright (c) 2009 Google Inc. All rights reserved.
33

44
Redistribution and use in source and binary forms, with or without

tools/gyp/pylib/gyp/common.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,7 @@ def __init__(self):
364364
dir=base_temp_dir,
365365
)
366366
try:
367-
self.tmp_file = os.fdopen(tmp_fd, "w")
367+
self.tmp_file = os.fdopen(tmp_fd, "wb")
368368
except Exception:
369369
# Don't leave turds behind.
370370
os.unlink(self.tmp_path)

tools/gyp/setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
setup(
1717
name="gyp-next",
18-
version="0.2.0",
18+
version="0.2.1",
1919
description="A fork of the GYP build system for use in the Node.js projects",
2020
long_description=long_description,
2121
long_description_content_type="text/markdown",

0 commit comments

Comments
 (0)