Skip to content

Commit

Permalink
src: use default parameters for UVException()
Browse files Browse the repository at this point in the history
PR-URL: #23176
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
addaleax authored and danbev committed Oct 4, 2018
1 parent 69a422b commit 51f0060
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 16 deletions.
9 changes: 0 additions & 9 deletions src/exceptions.cc
Original file line number Diff line number Diff line change
Expand Up @@ -84,15 +84,6 @@ static Local<String> StringFromPath(Isolate* isolate, const char* path) {
}


Local<Value> UVException(Isolate* isolate,
int errorno,
const char* syscall,
const char* msg,
const char* path) {
return UVException(isolate, errorno, syscall, msg, path, nullptr);
}


Local<Value> UVException(Isolate* isolate,
int errorno,
const char* syscall,
Expand Down
9 changes: 2 additions & 7 deletions src/node.h
Original file line number Diff line number Diff line change
Expand Up @@ -118,13 +118,8 @@ NODE_EXTERN v8::Local<v8::Value> UVException(v8::Isolate* isolate,
int errorno,
const char* syscall = nullptr,
const char* message = nullptr,
const char* path = nullptr);
NODE_EXTERN v8::Local<v8::Value> UVException(v8::Isolate* isolate,
int errorno,
const char* syscall,
const char* message,
const char* path,
const char* dest);
const char* path = nullptr,
const char* dest = nullptr);

NODE_DEPRECATED("Use ErrnoException(isolate, ...)",
inline v8::Local<v8::Value> ErrnoException(
Expand Down

0 comments on commit 51f0060

Please sign in to comment.