Skip to content

Commit

Permalink
build: disable custom v8 snapshot by default
Browse files Browse the repository at this point in the history
This currently breaks `test/pummel/test-hash-seed.js`

PR-URL: #27365
Refs: #27321
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
  • Loading branch information
joyeecheung authored and targos committed Apr 27, 2019
1 parent d62a324 commit 5023446
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 1 deletion.
12 changes: 12 additions & 0 deletions configure.py
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,11 @@
dest='with_ltcg',
help='Use Link Time Code Generation. This feature is only available on Windows.')

parser.add_option('--with-node-snapshot',
action='store_true',
dest='with_node_snapshot',
help='Turn on V8 snapshot integration. Currently experimental.')

intl_optgroup.add_option('--download',
action='store',
dest='download_list',
Expand Down Expand Up @@ -928,6 +933,13 @@ def configure_node(o):
o['variables']['want_separate_host_toolset'] = int(
cross_compiling and want_snapshots)

if options.with_node_snapshot:
o['variables']['node_use_node_snapshot'] = 'true'
else:
# Default to false for now.
# TODO(joyeecheung): enable it once we fix the hashseed uniqueness
o['variables']['node_use_node_snapshot'] = 'false'

if target_arch == 'arm':
configure_arm(o)

Expand Down
3 changes: 2 additions & 1 deletion node.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
'node_use_dtrace%': 'false',
'node_use_etw%': 'false',
'node_no_browser_globals%': 'false',
'node_use_node_snapshot%': 'false',
'node_use_v8_platform%': 'true',
'node_use_bundled_v8%': 'true',
'node_shared%': 'false',
Expand Down Expand Up @@ -431,7 +432,7 @@
'src/node_code_cache_stub.cc'
],
}],
['want_separate_host_toolset==0', {
['node_use_node_snapshot=="true"', {
'dependencies': [
'node_mksnapshot',
],
Expand Down

0 comments on commit 5023446

Please sign in to comment.