Skip to content

Commit 5023446

Browse files
joyeecheungtargos
authored andcommitted
build: disable custom v8 snapshot by default
This currently breaks `test/pummel/test-hash-seed.js` PR-URL: #27365 Refs: #27321 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
1 parent d62a324 commit 5023446

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

configure.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -421,6 +421,11 @@
421421
dest='with_ltcg',
422422
help='Use Link Time Code Generation. This feature is only available on Windows.')
423423

424+
parser.add_option('--with-node-snapshot',
425+
action='store_true',
426+
dest='with_node_snapshot',
427+
help='Turn on V8 snapshot integration. Currently experimental.')
428+
424429
intl_optgroup.add_option('--download',
425430
action='store',
426431
dest='download_list',
@@ -928,6 +933,13 @@ def configure_node(o):
928933
o['variables']['want_separate_host_toolset'] = int(
929934
cross_compiling and want_snapshots)
930935

936+
if options.with_node_snapshot:
937+
o['variables']['node_use_node_snapshot'] = 'true'
938+
else:
939+
# Default to false for now.
940+
# TODO(joyeecheung): enable it once we fix the hashseed uniqueness
941+
o['variables']['node_use_node_snapshot'] = 'false'
942+
931943
if target_arch == 'arm':
932944
configure_arm(o)
933945

node.gyp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
'node_use_dtrace%': 'false',
77
'node_use_etw%': 'false',
88
'node_no_browser_globals%': 'false',
9+
'node_use_node_snapshot%': 'false',
910
'node_use_v8_platform%': 'true',
1011
'node_use_bundled_v8%': 'true',
1112
'node_shared%': 'false',
@@ -431,7 +432,7 @@
431432
'src/node_code_cache_stub.cc'
432433
],
433434
}],
434-
['want_separate_host_toolset==0', {
435+
['node_use_node_snapshot=="true"', {
435436
'dependencies': [
436437
'node_mksnapshot',
437438
],

0 commit comments

Comments
 (0)