crypto: runtime-deprecate default shake128/256 output lengths

Author: panva

doc/api/deprecations.md

@@ -4065,6 +4065,9 @@ The [`util.types.isNativeError`][] API is deprecated. Please use [`Error.isError
 
 <!-- YAML
 changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/00000
+    description: Runtime deprecation.
   - version: v24.4.0
     pr-url: https://github.com/nodejs/node/pull/58942
     description: Documentation-only deprecation with support for `--pending-deprecation`.

lib/internal/crypto/hash.js

@@ -34,7 +34,6 @@ const {
   lazyDOMException,
   normalizeEncoding,
   encodingsMap,
-  isPendingDeprecation,
   getDeprecationWarningEmitter,
 } = require('internal/util');
 
@@ -80,7 +79,6 @@ const maybeEmitDeprecationWarning = getDeprecationWarningEmitter(
   undefined,
   false,
   (algorithm) => {
-    if (!isPendingDeprecation()) return false;
     const normalized = normalizeAlgorithm(algorithm);
     return normalized === 'shake128' || normalized === 'shake256';
   },

src/crypto/crypto_hash.cc

@@ -251,6 +251,7 @@ void Hash::OneShotDigest(const FunctionCallbackInfo<Value>& args) {
     } else if (output_length == 0) {
       // This is to handle OpenSSL 3.4's breaking change in SHAKE128/256
       // default lengths
+      // TODO(@panva): remove this behaviour when DEP0198 is End-Of-Life
       const char* name = OBJ_nid2sn(EVP_MD_type(md));
       if (name != nullptr) {
         if (strcmp(name, "SHAKE128") == 0) {
@@ -379,6 +380,9 @@ bool Hash::HashInit(const EVP_MD* md, Maybe<unsigned int> xof_md_len) {
   }
 
   md_len_ = mdctx_.getDigestSize();
+
+  // This is to handle OpenSSL 3.4's breaking change in SHAKE128/256
+  // default lengths
   // TODO(@panva): remove this behaviour when DEP0198 is End-Of-Life
   if (mdctx_.hasXofFlag() && !xof_md_len.IsJust() && md_len_ == 0) {
     const char* name = OBJ_nid2sn(EVP_MD_type(md));

test/parallel/test-crypto-default-shake-lengths-oneshot.js

@@ -1,4 +1,3 @@
-// Flags: --pending-deprecation
 'use strict';
 
 const common = require('../common');

test/parallel/test-crypto-default-shake-lengths.js

@@ -1,4 +1,3 @@
-// Flags: --pending-deprecation
 'use strict';
 
 const common = require('../common');