Skip to content

Commit 4f04a36

Browse files
authored
test: avoid flaky debugger restart waits
PR-URL: #61773 Refs: #61762 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 787aeff commit 4f04a36

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

test/parallel/test-debugger-restart-message.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,11 @@ const startCLI = require('../common/debugger');
2525
assert.strictEqual(cli.output.match(listeningRegExp).length, 1);
2626

2727
for (let i = 0; i < RESTARTS; i++) {
28-
await cli.stepCommand('restart');
28+
// For `restart`, sync on attach/prompt instead of BREAK_MESSAGE to avoid flaky races.
29+
// https://github.com/nodejs/node/issues/61762
30+
await cli.command('restart');
31+
await cli.waitFor(/Debugger attached\./);
32+
await cli.waitForPrompt();
2933
assert.strictEqual(cli.output.match(listeningRegExp).length, 1);
3034
}
3135
} finally {

test/parallel/test-debugger-run-after-quit-restart.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ const path = require('path');
5757
{ filename: script, line: 2 },
5858
);
5959
})
60-
.then(() => cli.stepCommand('restart'))
60+
.then(() => cli.command('restart'))
6161
.then(() => cli.waitForInitialBreak())
6262
.then(() => {
6363
assert.deepStrictEqual(

0 commit comments

Comments
 (0)