From 4ec2d925b175dc024050ace615396ab6e67d527d Mon Sep 17 00:00:00 2001
From: Yagiz Nizipli <yagiz@nizipli.com>
Date: Tue, 6 Jun 2023 21:33:59 -0400
Subject: [PATCH] module: reduce url invocations in esm/load.js

PR-URL: https://github.com/nodejs/node/pull/48337
Refs: https://github.com/nodejs/performance/issues/92
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
---
 lib/internal/modules/esm/load.js | 31 ++++++++++++++++++-------------
 1 file changed, 18 insertions(+), 13 deletions(-)

diff --git a/lib/internal/modules/esm/load.js b/lib/internal/modules/esm/load.js
index c929fcc649c9f1..fbd86e2881c0f0 100644
--- a/lib/internal/modules/esm/load.js
+++ b/lib/internal/modules/esm/load.js
@@ -29,26 +29,31 @@ const {
 
 const DATA_URL_PATTERN = /^[^/]+\/[^,;]+(?:[^,]*?)(;base64)?,([\s\S]*)$/;
 
+/**
+ * @param {URL} url URL to the module
+ * @param {ESModuleContext} context used to decorate error messages
+ * @returns {{ responseURL: string, source: string | BufferView }}
+ */
 async function getSource(url, context) {
-  const parsed = new URL(url);
-  let responseURL = url;
+  const { protocol, href } = url;
+  let responseURL = href;
   let source;
-  if (parsed.protocol === 'file:') {
+  if (protocol === 'file:') {
     const { readFile: readFileAsync } = require('internal/fs/promises').exports;
-    source = await readFileAsync(parsed);
-  } else if (parsed.protocol === 'data:') {
-    const match = RegExpPrototypeExec(DATA_URL_PATTERN, parsed.pathname);
+    source = await readFileAsync(url);
+  } else if (protocol === 'data:') {
+    const match = RegExpPrototypeExec(DATA_URL_PATTERN, url.pathname);
     if (!match) {
-      throw new ERR_INVALID_URL(url);
+      throw new ERR_INVALID_URL(responseURL);
     }
     const { 1: base64, 2: body } = match;
     source = BufferFrom(decodeURIComponent(body), base64 ? 'base64' : 'utf8');
   } else if (experimentalNetworkImports && (
-    parsed.protocol === 'https:' ||
-    parsed.protocol === 'http:'
+    protocol === 'https:' ||
+    protocol === 'http:'
   )) {
     const { fetchModule } = require('internal/modules/esm/fetch_module');
-    const res = await fetchModule(parsed, context);
+    const res = await fetchModule(url, context);
     source = await res.body;
     responseURL = res.resolvedHREF;
   } else {
@@ -56,10 +61,10 @@ async function getSource(url, context) {
     if (experimentalNetworkImports) {
       ArrayPrototypePush(supportedSchemes, 'http', 'https');
     }
-    throw new ERR_UNSUPPORTED_ESM_URL_SCHEME(parsed, supportedSchemes);
+    throw new ERR_UNSUPPORTED_ESM_URL_SCHEME(url, supportedSchemes);
   }
   if (policy?.manifest) {
-    policy.manifest.assertIntegrity(parsed, source);
+    policy.manifest.assertIntegrity(href, source);
   }
   return { __proto__: null, responseURL, source };
 }
@@ -93,7 +98,7 @@ async function defaultLoad(url, context = kEmptyObject) {
   ) {
     source = null;
   } else if (source == null) {
-    ({ responseURL, source } = await getSource(url, context));
+    ({ responseURL, source } = await getSource(urlInstance, context));
   }
 
   return {