Skip to content

Commit 4e0a0d5

Browse files
Chris911Myles Borins
authored and
Myles Borins
committed
src: remove no longer relevant comments
PR-URL: #4843 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
1 parent 063e14b commit 4e0a0d5

File tree

3 files changed

+2
-4
lines changed

3 files changed

+2
-4
lines changed

src/debug-agent.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,6 @@ void Agent::ChildSignalCb(uv_async_t* signal) {
285285
}
286286

287287
// Waiting for client, do not send anything just yet
288-
// TODO(indutny): move this to js-land
289288
if (a->wait_) {
290289
a->messages_.PushFront(msg); // Push message back into the ready queue.
291290
break;

src/debug-agent.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,6 @@ class Agent {
109109
kRunning
110110
};
111111

112-
// TODO(indutny): Verify that there are no races
113112
State state_;
114113

115114
int port_;

src/node_crypto.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4975,7 +4975,7 @@ void PBKDF2(const FunctionCallbackInfo<Value>& args) {
49754975

49764976
if (args[5]->IsFunction()) {
49774977
obj->Set(env->ondone_string(), args[5]);
4978-
// XXX(trevnorris): This will need to go with the rest of domains.
4978+
49794979
if (env->in_domain())
49804980
obj->Set(env->domain_string(), env->domain_array()->Get(0));
49814981
uv_queue_work(env->event_loop(),
@@ -5136,7 +5136,7 @@ void RandomBytes(const FunctionCallbackInfo<Value>& args) {
51365136

51375137
if (args[1]->IsFunction()) {
51385138
obj->Set(FIXED_ONE_BYTE_STRING(args.GetIsolate(), "ondone"), args[1]);
5139-
// XXX(trevnorris): This will need to go with the rest of domains.
5139+
51405140
if (env->in_domain())
51415141
obj->Set(env->domain_string(), env->domain_array()->Get(0));
51425142
uv_queue_work(env->event_loop(),

0 commit comments

Comments
 (0)