Skip to content

Commit 4dc920a

Browse files
barnskiBridgeAR
authored andcommitted
src: remove outdated todo from node_crypto.cc
TODO comment from node_crypto is no longer relevant. Unification of commented code and string_bytes code would bloat the latter. Methods for hex encoding produce different output in both files (crypto adds colon and uses uppercase letters.) Common path between those two is very limited now. PR-URL: #15104 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 049a8d7 commit 4dc920a

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

src/node_crypto.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1627,7 +1627,6 @@ static Local<Object> X509ToObject(Environment* env, X509* cert) {
16271627
const char hex[] = "0123456789ABCDEF";
16281628
char fingerprint[EVP_MAX_MD_SIZE * 3];
16291629

1630-
// TODO(indutny): Unify it with buffer's code
16311630
for (i = 0; i < md_size; i++) {
16321631
fingerprint[3*i] = hex[(md[i] & 0xf0) >> 4];
16331632
fingerprint[(3*i)+1] = hex[(md[i] & 0x0f)];

0 commit comments

Comments
 (0)