module: use options bag for stat and tryFile probe flags

Address review feedback: pass the resolution-probe flag as a named option
instead of a positional boolean, so callsites read

  tryFile(basePath + exts[i], { isMain, isSpeculativeProbe: true });
  _stat(curPath, { isSpeculativeProbe: true });

`isMain` moves into the bag as well rather than staying positional, and
`stat` gets the same treatment since that is where the flag is consumed.
Both default to `kEmptyObject`, matching the existing idiom in this file.

No behaviour change: the negative-caching scope is identical and the
existing tests pass unmodified.

Signed-off-by: Maxime David <maxday@amazon.com>

Author: maxday

lib/internal/modules/cjs/loader.js

@@ -281,12 +281,13 @@ function wrapModuleLoad(request, parent, isMain, options) {
  * is missing on a failed `require()` and then created can still be picked up by
  * a later `require()` in the same tree.
  * @param {string} filename Absolute path to the file
- * @param {boolean} [isSpeculativeProbe] Whether this is a resolution guess
- *   rather than a path the user named, which makes the negative result
+ * @param {object} [options]
+ * @param {boolean} [options.isSpeculativeProbe] Whether this is a resolution
+ *   guess rather than a path the user named, which makes the negative result
  *   cacheable and lets a previously cached negative be reused.
  * @returns {number}
  */
-function stat(filename, isSpeculativeProbe = false) {
+function stat(filename, { isSpeculativeProbe = false } = kEmptyObject) {
   // Guard against internal bugs where a non-string filename is passed in by mistake.
   assert(typeof filename === 'string');
 
@@ -576,7 +577,7 @@ function tryPackage(requestPath, exts, isMain, originalPath) {
   }
 
   const filename = path.resolve(requestPath, pkg);
-  let actual = tryFile(filename, isMain) ||
+  let actual = tryFile(filename, { isMain }) ||
     tryExtensions(filename, exts, isMain) ||
     tryExtensions(path.resolve(filename, 'index'), exts, isMain);
   if (actual === false) {
@@ -608,13 +609,14 @@ function tryPackage(requestPath, exts, isMain, originalPath) {
  * Check if the file exists and is not a directory if using `--preserve-symlinks` and `isMain` is false or
  * `--preserve-symlinks-main` and `isMain` is true , keep symlinks intact, otherwise resolve to the absolute realpath.
  * @param {string} requestPath The path to the file to load.
- * @param {boolean} isMain Whether the file is the main module.
- * @param {boolean} [isSpeculativeProbe] Whether `requestPath` is a resolution
- *   guess rather than a path the user named. See {@link stat}.
+ * @param {object} [options]
+ * @param {boolean} [options.isMain] Whether the file is the main module.
+ * @param {boolean} [options.isSpeculativeProbe] Whether `requestPath` is a
+ *   resolution guess rather than a path the user named. See {@link stat}.
  * @returns {string|undefined}
  */
-function tryFile(requestPath, isMain, isSpeculativeProbe = false) {
-  const rc = _stat(requestPath, isSpeculativeProbe);
+function tryFile(requestPath, { isMain = false, isSpeculativeProbe = false } = kEmptyObject) {
+  const rc = _stat(requestPath, { isSpeculativeProbe });
   if (rc !== 0) { return; }
   if (getOptionValue(isMain ? '--preserve-symlinks-main' : '--preserve-symlinks')) {
     return path.resolve(requestPath);
@@ -633,7 +635,7 @@ function tryFile(requestPath, isMain, isSpeculativeProbe = false) {
  */
 function tryExtensions(basePath, exts, isMain) {
   for (let i = 0; i < exts.length; i++) {
-    const filename = tryFile(basePath + exts[i], isMain, true);
+    const filename = tryFile(basePath + exts[i], { isMain, isSpeculativeProbe: true });
 
     if (filename) {
       return filename;
@@ -847,7 +849,7 @@ Module._findPath = function(request, paths, isMain, conditions = getCjsCondition
     // A candidate lookup directory (typically a `node_modules` ancestor) is a
     // speculative probe: most of the chain does not exist, and every bare
     // specifier in the tree re-walks the same missing ancestors.
-    if (insidePath && curPath && _stat(curPath, true) < 1) {
+    if (insidePath && curPath && _stat(curPath, { isSpeculativeProbe: true }) < 1) {
       continue;
     }