crypto: fix regression on randomFillSync

Signed-off-by: James M Snell <jasnell@gmail.com>

Fixes: #35722
PR-URL: #35723
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>

Author: jasnell

lib/internal/crypto/random.js

@@ -113,7 +113,7 @@ function randomFillSync(buf, offset = 0, size) {
 
   const job = new RandomBytesJob(
     kCryptoJobSync,
-    buf.buffer || buf,
+    buf,
     offset,
     size);
 

test/parallel/test-crypto-randomfillsync-regression.js

@@ -0,0 +1,18 @@
+'use strict';
+const common = require('../common');
+if (!common.hasCrypto)
+  common.skip('missing crypto');
+
+const { randomFillSync } = require('crypto');
+const { notStrictEqual } = require('assert');
+
+const ab = new ArrayBuffer(20);
+const buf = Buffer.from(ab, 10);
+
+const before = buf.toString('hex');
+
+randomFillSync(buf);
+
+const after = buf.toString('hex');
+
+notStrictEqual(before, after);