Skip to content

Commit 4bf62f6

Browse files
benjamingraduh95
authored andcommitted
stream: improve inspector ergonomics
PR-URL: #53800 Fixes: #53789 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
1 parent ab8abb5 commit 4bf62f6

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

lib/internal/webstreams/readablestream.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -2041,8 +2041,8 @@ function readableStreamError(stream, error) {
20412041
assert(stream[kState].state === 'readable');
20422042
stream[kState].state = 'errored';
20432043
stream[kState].storedError = error;
2044-
stream[kIsClosedPromise].reject(error);
20452044
setPromiseHandled(stream[kIsClosedPromise].promise);
2045+
stream[kIsClosedPromise].reject(error);
20462046

20472047
const {
20482048
reader,
@@ -2051,8 +2051,8 @@ function readableStreamError(stream, error) {
20512051
if (reader === undefined)
20522052
return;
20532053

2054-
reader[kState].close.reject(error);
20552054
setPromiseHandled(reader[kState].close.promise);
2055+
reader[kState].close.reject(error);
20562056

20572057
if (readableStreamHasDefaultReader(stream)) {
20582058
for (let n = 0; n < reader[kState].readRequests.length; n++)

lib/internal/webstreams/writablestream.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -768,15 +768,15 @@ function writableStreamRejectCloseAndClosedPromiseIfNeeded(stream) {
768768
};
769769
}
770770

771-
stream[kIsClosedPromise].reject(stream[kState]?.storedError);
772771
setPromiseHandled(stream[kIsClosedPromise].promise);
772+
stream[kIsClosedPromise].reject(stream[kState]?.storedError);
773773

774774
const {
775775
writer,
776776
} = stream[kState];
777777
if (writer !== undefined) {
778-
writer[kState].close.reject?.(stream[kState].storedError);
779778
setPromiseHandled(writer[kState].close.promise);
779+
writer[kState].close.reject?.(stream[kState].storedError);
780780
}
781781
}
782782

0 commit comments

Comments
 (0)