From 4ad3479ba7f01415c3cbdcbec0e617c6085002d8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Wed, 13 Sep 2023 16:58:22 +0200 Subject: [PATCH] deps: V8: cherry-pick 1a3ecc2483b2 Original commit message: Fix build issue, remove unneeded include uchar.h. Follow the conversation on: https://groups.google.com/g/v8-dev/c/nsbshwlmP3c. The `uchar.h` include is not necessary. It was added to get the definition of char16_t but that's an intrinsic type in C++. Change-Id: I0aaa11dba0be3ccad15b9e421f8bae71450d443b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4823404 Reviewed-by: Omer Katz Commit-Queue: Eric Leese Reviewed-by: Eric Leese Cr-Commit-Position: refs/heads/main@{#89787} Refs: https://github.com/v8/v8/commit/1a3ecc2483b2dba6ab9f7e9f8f4b60dbfef504b7 PR-URL: https://github.com/nodejs/node/pull/49639 Reviewed-By: Jiawen Geng Reviewed-By: Rafael Gonzaga Reviewed-By: Antoine du Hamel --- common.gypi | 2 +- deps/v8/AUTHORS | 1 + deps/v8/src/inspector/string-16.h | 1 - deps/v8/src/inspector/v8-string-conversions.h | 1 - 4 files changed, 2 insertions(+), 3 deletions(-) diff --git a/common.gypi b/common.gypi index 96378a9eb48639..f2d4663e0bbc17 100644 --- a/common.gypi +++ b/common.gypi @@ -36,7 +36,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.6', + 'v8_embedder_string': '-node.7', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/AUTHORS b/deps/v8/AUTHORS index faae93dbf7ff77..b9b702c5d22400 100644 --- a/deps/v8/AUTHORS +++ b/deps/v8/AUTHORS @@ -194,6 +194,7 @@ Matt Hanselman Matthew Sporleder Maxim Mazurok Maxim Mossienko +Meir Shpilraien Michael Lutz Michael Mclaughlin Michael Smith diff --git a/deps/v8/src/inspector/string-16.h b/deps/v8/src/inspector/string-16.h index d9f6c466ab17c2..a0dd965792afab 100644 --- a/deps/v8/src/inspector/string-16.h +++ b/deps/v8/src/inspector/string-16.h @@ -6,7 +6,6 @@ #define V8_INSPECTOR_STRING_16_H_ #include -#include #include #include diff --git a/deps/v8/src/inspector/v8-string-conversions.h b/deps/v8/src/inspector/v8-string-conversions.h index 1126255dac23c9..0f674f0bc81947 100644 --- a/deps/v8/src/inspector/v8-string-conversions.h +++ b/deps/v8/src/inspector/v8-string-conversions.h @@ -5,7 +5,6 @@ #ifndef V8_INSPECTOR_V8_STRING_CONVERSIONS_H_ #define V8_INSPECTOR_V8_STRING_CONVERSIONS_H_ -#include #include #include