vm: move process.binding('contextify') to internalBinding

PR-URL: #22419 Refs: #22160 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
nodejs · Aug 23, 2018 · 4963a04 · 4963a04
1 parent 3b5c992
commit 4963a04
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 5 deletions.
diff --git a/lib/internal/bootstrap/loaders.js b/lib/internal/bootstrap/loaders.js
@@ -107,7 +107,7 @@
     };
   }
 
-  const { ContextifyScript } = process.binding('contextify');
+  const { ContextifyScript } = internalBinding('contextify');
 
   // Set up NativeModule
   function NativeModule(id) {

diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
@@ -351,7 +351,8 @@
         'v8',
         'stream_wrap',
         'signal_wrap',
-        'crypto']);
+        'crypto',
+        'contextify']);
     process.binding = function binding(name) {
       return internalBindingWhitelist.has(name) ?
         internalBinding(name) :

diff --git a/lib/internal/vm/source_text_module.js b/lib/internal/vm/source_text_module.js
@@ -2,7 +2,7 @@
 
 const { internalBinding } = require('internal/bootstrap/loaders');
 const { URL } = require('internal/url');
-const { isContext } = process.binding('contextify');
+const { isContext } = internalBinding('contextify');
 const {
   ERR_INVALID_ARG_TYPE,
   ERR_VM_MODULE_ALREADY_LINKED,

diff --git a/lib/vm.js b/lib/vm.js
@@ -21,11 +21,12 @@
 
 'use strict';
 
+const { internalBinding } = require('internal/bootstrap/loaders');
 const {
   ContextifyScript,
   makeContext,
   isContext: _isContext,
-} = process.binding('contextify');
+} = internalBinding('contextify');
 const { ERR_INVALID_ARG_TYPE } = require('internal/errors').codes;
 const { isUint8Array } = require('internal/util/types');
 const { validateInt32, validateUint32 } = require('internal/validators');

diff --git a/src/node_contextify.cc b/src/node_contextify.cc
@@ -958,4 +958,4 @@ void Initialize(Local<Object> target,
 }  // namespace contextify
 }  // namespace node
 
-NODE_BUILTIN_MODULE_CONTEXT_AWARE(contextify, node::contextify::Initialize)
+NODE_MODULE_CONTEXT_AWARE_INTERNAL(contextify, node::contextify::Initialize)
diff --git a/test/parallel/test-process-binding-internalbinding-whitelist.js b/test/parallel/test-process-binding-internalbinding-whitelist.js
@@ -11,3 +11,4 @@ assert(process.binding('http_parser'));
 assert(process.binding('v8'));
 assert(process.binding('stream_wrap'));
 assert(process.binding('signal_wrap'));
+assert(process.binding('contextify'));