Skip to content

Commit 4839fc4

Browse files
KhafraDevtargos
authored andcommitted
url: validate argument length in canParse
PR-URL: #47513 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
1 parent ede69d2 commit 4839fc4

File tree

2 files changed

+16
-0
lines changed

2 files changed

+16
-0
lines changed

lib/internal/url.js

+4
Original file line numberDiff line numberDiff line change
@@ -978,6 +978,10 @@ class URL {
978978
}
979979

980980
static canParse(url, base = undefined) {
981+
if (arguments.length === 0) {
982+
throw new ERR_MISSING_ARGS('url');
983+
}
984+
981985
url = `${url}`;
982986

983987
if (base !== undefined) {
+12
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
'use strict';
2+
3+
require('../common');
4+
const assert = require('assert');
5+
6+
// One argument is required
7+
assert.throws(() => {
8+
URL.canParse();
9+
}, {
10+
code: 'ERR_MISSING_ARGS',
11+
name: 'TypeError'
12+
});

0 commit comments

Comments
 (0)