Skip to content

Commit 47f1c52

Browse files
committed
deps: silence irrelevant V8 warning
PR-URL: #37330 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 19d9752 commit 47f1c52

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.8',
39+
'v8_embedder_string': '-node.9',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/include/v8.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -1631,7 +1631,7 @@ class V8_EXPORT Module : public Data {
16311631
*/
16321632
int GetIdentityHash() const;
16331633

1634-
using ResolveCallback V8_DEPRECATE_SOON("Use ResolveModuleCallback") =
1634+
using ResolveCallback =
16351635
MaybeLocal<Module> (*)(Local<Context> context, Local<String> specifier,
16361636
Local<Module> referrer);
16371637
using ResolveModuleCallback = MaybeLocal<Module> (*)(

0 commit comments

Comments
 (0)