fixup! fixup! src: migrate from deprecated SnapshotCreator constructor

Author: joyeecheung

src/api/embed_helpers.cc

@@ -234,10 +234,10 @@ CommonEnvironmentSetup::~CommonEnvironmentSetup() {
     impl_->platform->AddIsolateFinishedCallback(isolate, [](void* data) {
       *static_cast<bool*>(data) = true;
     }, &platform_finished);
-    if (impl_->snapshot_creator.has_value())
+    if (impl_->snapshot_creator.has_value()) {
       impl_->snapshot_creator.reset();
-    else
-      isolate->Dispose();
+    }
+    isolate->Dispose();
     impl_->platform->UnregisterIsolate(isolate);
 
     // Wait until the platform has cleaned up all relevant resources.