Skip to content

Commit

Permalink
test: fix flaky async-hooks/test-callback-error
Browse files Browse the repository at this point in the history
Remove an unnecessary timeout.

Fixes: #15985

PR-URL: #22655
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
addaleax authored and targos committed Sep 5, 2018
1 parent c26747d commit 4791cd7
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions test/async-hooks/test-callback-error.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,6 @@ assert.ok(!arg);
{
console.log('start case 3');
console.time('end case 3');
// Timeout is set because this case is known to be problematic, so stderr is
// logged for further analysis.
// Ref: https://github.com/nodejs/node/issues/13527
// Ref: https://github.com/nodejs/node/pull/13559
const opts = {
execArgv: ['--abort-on-uncaught-exception'],
silent: true
Expand All @@ -78,15 +74,7 @@ assert.ok(!arg);
stderr += data;
});

const tO = setTimeout(() => {
console.log(stderr);
child.kill('SIGKILL');
process.exit(1);
}, 15 * 1000);
tO.unref();

child.on('close', (code, signal) => {
clearTimeout(tO);
if (common.isWindows) {
assert.strictEqual(code, 134);
assert.strictEqual(signal, null);
Expand Down

0 comments on commit 4791cd7

Please sign in to comment.