console: prevent internal timers storage from growing

The instance of `Console` class doesn't remove links to arrays that come from hrtimer after `timeEnd` had been called.
nodejs · Nov 13, 2015 · 474c066 · 474c066
1 parent d9734b7
commit 474c066
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/lib/console.js b/lib/console.js
@@ -68,6 +68,7 @@ Console.prototype.timeEnd = function(label) {
   const duration = process.hrtime(time);
   const ms = duration[0] * 1000 + duration[1] / 1e6;
   this.log('%s: %sms', label, ms.toFixed(3));
+  this._times.delete(label);
 };
 
 

diff --git a/test/parallel/test-console.js b/test/parallel/test-console.js
@@ -57,6 +57,16 @@ console.timeEnd('hasOwnProperty');
 
 global.process.stdout.write = stdout_write;
 
+// verify that console.timeEnd() doesn't leave dead links
+const timesMapSize = console._times.size;
+console.time('label1');
+console.time('label2');
+console.time('label3');
+console.timeEnd('label1');
+console.timeEnd('label2');
+console.timeEnd('label3');
+assert.strictEqual(console._times.size, timesMapSize);
+
 assert.equal('foo\n', strings.shift());
 assert.equal('foo bar\n', strings.shift());
 assert.equal('foo bar hop\n', strings.shift());