From 4651cd721d3659e4841da1b9f7d35e8f884e65ab Mon Sep 17 00:00:00 2001 From: Refael Ackermann Date: Mon, 29 Oct 2018 14:40:38 -0400 Subject: [PATCH] build: add -Werror=undefined-inline to clang builds MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/23961 Refs: https://github.com/nodejs/node/pull/23954 Refs: https://github.com/nodejs/node/pull/23910 Refs: https://github.com/nodejs/node/pull/23880 Reviewed-By: Michaƫl Zasso Reviewed-By: Colin Ihrig Reviewed-By: Richard Lau Reviewed-By: Joyee Cheung --- node.gypi | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/node.gypi b/node.gypi index 0b27e6ad2c1ac4..eba49be69c3cc5 100644 --- a/node.gypi +++ b/node.gypi @@ -32,9 +32,13 @@ '-Wendif-labels', '-W', '-Wno-unused-parameter', + '-Werror=undefined-inline', ], }, 'conditions': [ + ['clang==1', { + 'cflags': [ '-Werror=undefined-inline', ] + }], [ 'node_shared=="false"', { 'msvs_settings': { 'VCManifestTool': {