src: disable abort exceptions for module loading

Author: anonrig

src/node_contextify.cc

@@ -1448,6 +1448,20 @@ void ContextifyContext::ContainsModuleSyntax(
     code = args[0].As<String>();
   }
 
+  // We need to temporarily disable aborting on uncaught exceptions because
+  // ScriptCompiler::CompileFunction will abort if it encounters an uncaught
+  // exception. This can be reproduced with `--abort-on-uncaught-exception`
+  // flag.
+  bool should_abort_on_uncaught_exception =
+      env->options()->abort_on_uncaught_exception;
+  // Validate that we're restoring the original value.
+  auto on_scope_leave =
+      OnScopeLeave([&env, &should_abort_on_uncaught_exception]() {
+        CHECK_EQ(env->options()->abort_on_uncaught_exception,
+                 should_abort_on_uncaught_exception);
+      });
+  env->options()->abort_on_uncaught_exception = false;
+
   // TODO(geoffreybooth): Centralize this rather than matching the logic in
   // cjs/loader.js and translators.js
   Local<String> script_id = String::Concat(
@@ -1491,6 +1505,10 @@ void ContextifyContext::ContainsModuleSyntax(
       }
     }
   }
+
+  env->options()->abort_on_uncaught_exception =
+      should_abort_on_uncaught_exception;
+
   args.GetReturnValue().Set(found_error_message_caused_by_module_syntax);
 }
 

test/es-module/test-esm-detect-ambiguous.mjs

@@ -235,3 +235,23 @@ describe('--experimental-detect-module', { concurrency: true }, () => {
     }
   });
 });
+
+// Validate temporarily disabling `--abort-on-uncaught-exception`
+// while running `containsModuleSyntax`.
+// Ref: https://github.com/nodejs/node/issues/50878
+describe('Wrapping a `require` of an ES module while using `--abort-on-uncaught-exception`', () => {
+  it('should work', async () => {
+    const { code, signal, stdout, stderr } = await spawnPromisified(process.execPath, [
+      '--abort-on-uncaught-exception',
+      '--eval',
+      'try { require("./package-type-module/esm.js") } catch (error) { console.log(error.code) }',
+    ], {
+      cwd: fixtures.path('es-modules'),
+    });
+
+    strictEqual(stderr, '');
+    strictEqual(stdout.trim(), 'ERR_REQUIRE_ESM');
+    strictEqual(code, 0);
+    strictEqual(signal, null);
+  });
+});