Skip to content

Commit 4259afe

Browse files
bnoordhuisMylesBorins
authored andcommitted
src: remove node::InitializeV8Platform()
This API method was introduced in commit 90ae4bd ("src: add InitializeV8Platform function") from July 2018 but wasn't properly exported and therefore not usable on Windows or with shared library builds. The motivation from the commit log is mainly about making it easier to wire up the cctests and there are better ways to do that. Refs: #31217 PR-URL: #31245 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent 6050236 commit 4259afe

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

src/api/environment.cc

-5
Original file line numberDiff line numberDiff line change
@@ -366,11 +366,6 @@ MultiIsolatePlatform* CreatePlatform(
366366
return new NodePlatform(thread_pool_size, tracing_controller);
367367
}
368368

369-
MultiIsolatePlatform* InitializeV8Platform(int thread_pool_size) {
370-
per_process::v8_platform.Initialize(thread_pool_size);
371-
return per_process::v8_platform.Platform();
372-
}
373-
374369
void FreePlatform(MultiIsolatePlatform* platform) {
375370
delete platform;
376371
}

src/node.h

-1
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,6 @@ NODE_EXTERN MultiIsolatePlatform* GetMainThreadMultiIsolatePlatform();
389389
NODE_EXTERN MultiIsolatePlatform* CreatePlatform(
390390
int thread_pool_size,
391391
node::tracing::TracingController* tracing_controller);
392-
MultiIsolatePlatform* InitializeV8Platform(int thread_pool_size);
393392
NODE_EXTERN void FreePlatform(MultiIsolatePlatform* platform);
394393

395394
NODE_EXTERN void EmitBeforeExit(Environment* env);

0 commit comments

Comments
 (0)