Skip to content

Commit

Permalink
tools: update V8 gypfiles for 8.1
Browse files Browse the repository at this point in the history
Co-authored-by: Ben Noordhuis <info@bnoordhuis.nl>
Co-authored-by: Michaël Zasso <targos@protonmail.com>
Co-authored-by: Richard Lau <riclau@uk.ibm.com>
Co-authored-by: Ujjwal Sharma <ryzokuken@igalia.com>

PR-URL: #32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
mmarchini committed Mar 18, 2020
1 parent 339c192 commit 405ae19
Show file tree
Hide file tree
Showing 4 changed files with 141 additions and 123 deletions.
2 changes: 1 addition & 1 deletion node.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
}],
[ 'node_use_bundled_v8=="true"', {
'dependencies': [
'tools/v8_gypfiles/v8.gyp:v8_maybe_snapshot',
'tools/v8_gypfiles/v8.gyp:v8_snapshot',
'tools/v8_gypfiles/v8.gyp:v8_libplatform',
],
}],
Expand Down
15 changes: 8 additions & 7 deletions tools/v8_gypfiles/features.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,6 @@
# Enable fast mksnapshot runs.
'v8_enable_fast_mksnapshot%': 0,

# Enable embedded builtins.
'v8_enable_embedded_builtins%': 1,

# Enable the registration of unwinding info for Windows/x64 and ARM64.
'v8_win64_unwinding_info%': 1,

Expand All @@ -129,7 +126,7 @@

# Enable pointer compression (sets -dV8_COMPRESS_POINTERS).
'v8_enable_pointer_compression%': 0,
'v8_enable_31bit_smis_on_64bit_arch%': 0,
'v8_enable_31bit_smis_on_64bit_arch%': 1,

# Sets -dOBJECT_PRINT.
'v8_enable_object_print%': 0,
Expand All @@ -149,6 +146,9 @@
# Sets -dV8_CONCURRENT_MARKING
'v8_enable_concurrent_marking%': 1,

# Sets -dV8_ARRAY_BUFFER_EXTENSION
'v8_enable_array_buffer_extension%': 0,

# Enables various testing features.
'v8_enable_test_features%': 0,

Expand Down Expand Up @@ -295,15 +295,15 @@
['v8_enable_concurrent_marking==1', {
'defines': ['V8_CONCURRENT_MARKING',],
}],
['v8_enable_array_buffer_extension==1', {
'defines': ['V8_ARRAY_BUFFER_EXTENSION',],
}],
['v8_enable_lazy_source_positions==1', {
'defines': ['V8_ENABLE_LAZY_SOURCE_POSITIONS',],
}],
['v8_check_microtasks_scopes_consistency==1', {
'defines': ['V8_CHECK_MICROTASKS_SCOPES_CONSISTENCY',],
}],
['v8_enable_embedded_builtins==1', {
'defines': ['V8_EMBEDDED_BUILTINS',],
}],
['v8_use_siphash==1', {
'defines': ['V8_USE_SIPHASH',],
}],
Expand All @@ -327,6 +327,7 @@
}],
], # conditions
'defines': [
'V8_EMBEDDED_BUILTINS',
'V8_GYP_BUILD',
'V8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=<(v8_typed_array_max_size_in_heap)',
], # defines
Expand Down
28 changes: 17 additions & 11 deletions tools/v8_gypfiles/inspector.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,6 @@
'<(V8_ROOT)/src/inspector/v8-heap-profiler-agent-impl.h',
'<(V8_ROOT)/src/inspector/v8-inspector-impl.cc',
'<(V8_ROOT)/src/inspector/v8-inspector-impl.h',
'<(V8_ROOT)/src/inspector/v8-inspector-protocol-encoding.cc',
'<(V8_ROOT)/src/inspector/v8-inspector-protocol-encoding.h',
'<(V8_ROOT)/src/inspector/v8-inspector-session-impl.cc',
'<(V8_ROOT)/src/inspector/v8-inspector-session-impl.h',
'<(V8_ROOT)/src/inspector/v8-profiler-agent-impl.cc',
Expand All @@ -104,18 +102,26 @@
'<(V8_ROOT)/src/inspector/v8-value-utils.h',
'<(V8_ROOT)/src/inspector/value-mirror.cc',
'<(V8_ROOT)/src/inspector/value-mirror.h',
'<(V8_ROOT)/src/inspector/wasm-translation.cc',
'<(V8_ROOT)/src/inspector/wasm-translation.h',
# Flat merge `third_party/inspector_protocol:inspector_string_conversions`
'<(inspector_path)/v8-string-conversions.cc',
'<(inspector_path)/v8-string-conversions.h',
# Flat merge `third_party/inspector_protocol:encoding`
'<(inspector_protocol_path)/encoding/encoding.cc',
'<(inspector_protocol_path)/encoding/encoding.h',
# Flat merge `third_party/inspector_protocol:bindings`
'<(inspector_protocol_path)/bindings/bindings.cc',
'<(inspector_protocol_path)/bindings/bindings.h',

# Flat merge `third_party/inspector_protocal:crdtp_platform`
'<(inspector_protocol_path)/crdtp/json_platform.h',
'<(inspector_protocol_path)/crdtp/json_platform_v8.cc',
# Flat merge `third_party/inspector_protocol:crdtp`
'<(inspector_protocol_path)/crdtp/cbor.cc',
'<(inspector_protocol_path)/crdtp/cbor.h',
'<(inspector_protocol_path)/crdtp/export.h',
'<(inspector_protocol_path)/crdtp/glue.h',
'<(inspector_protocol_path)/crdtp/json.cc',
'<(inspector_protocol_path)/crdtp/json.h',
'<(inspector_protocol_path)/crdtp/parser_handler.h',
'<(inspector_protocol_path)/crdtp/serializable.cc',
'<(inspector_protocol_path)/crdtp/serializable.h',
'<(inspector_protocol_path)/crdtp/serializer_traits.h',
'<(inspector_protocol_path)/crdtp/span.h',
'<(inspector_protocol_path)/crdtp/status.cc',
'<(inspector_protocol_path)/crdtp/status.h',
],
'v8_inspector_js_protocol': '<(V8_ROOT)/include/js_protocol.pdl',
},
Expand Down
Loading

0 comments on commit 405ae19

Please sign in to comment.