-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test_runner: fixed
test
shorthands return type
`test.todo`, `test.only` and `test.skip` are expected to return the same as `test`. This commit corrects the inconsistent behavior of these shorthands. Fixes: #48557 PR-URL: #48555 Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
- Loading branch information
Showing
2 changed files
with
37 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
'use strict'; | ||
require('../common'); | ||
|
||
// Return type of shorthands should be consistent | ||
// with the return type of test | ||
|
||
const assert = require('assert'); | ||
const { test, describe, it } = require('node:test'); | ||
const { isPromise } = require('util/types'); | ||
|
||
const testOnly = test('only test', { only: true }); | ||
const testTodo = test('todo test', { todo: true }); | ||
const testSkip = test('skip test', { skip: true }); | ||
const testOnlyShorthand = test.only('only test shorthand'); | ||
const testTodoShorthand = test.todo('todo test shorthand'); | ||
const testSkipShorthand = test.skip('skip test shorthand'); | ||
|
||
describe('\'node:test\' and its shorthands should return the same', () => { | ||
it('should return a Promise', () => { | ||
assert(isPromise(testOnly)); | ||
assert(isPromise(testTodo)); | ||
assert(isPromise(testSkip)); | ||
assert(isPromise(testOnlyShorthand)); | ||
assert(isPromise(testTodoShorthand)); | ||
assert(isPromise(testSkipShorthand)); | ||
}); | ||
|
||
it('should resolve undefined', async () => { | ||
assert.strictEqual(await testOnly, undefined); | ||
assert.strictEqual(await testTodo, undefined); | ||
assert.strictEqual(await testSkip, undefined); | ||
assert.strictEqual(await testOnlyShorthand, undefined); | ||
assert.strictEqual(await testTodoShorthand, undefined); | ||
assert.strictEqual(await testSkipShorthand, undefined); | ||
}); | ||
}); |