Skip to content

Commit 3fa7ad3

Browse files
cjihrigMylesBorins
authored andcommitted
deps: update V8 postmortem metadata script
This commit updates V8's gen-postmortem-metadata.py script to fix SmartOS compilation for V8 8.4. Backport-PR-URL: #34356 PR-URL: #33579 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>
1 parent 4c37837 commit 3fa7ad3

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.11',
39+
'v8_embedder_string': '-node.12',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/tools/gen-postmortem-metadata.py

+1
Original file line numberDiff line numberDiff line change
@@ -279,6 +279,7 @@
279279
'SlicedString, offset, SMI, kOffsetOffset',
280280
'ThinString, actual, String, kActualOffset',
281281
'Symbol, name, Object, kDescriptionOffset',
282+
'FixedArrayBase, length, SMI, kLengthOffset',
282283
];
283284

284285
#

0 commit comments

Comments
 (0)