lib: rename setupInstance to finalizeBindings

Author: toyobayashi

lib/wasi.js

@@ -114,17 +114,21 @@ class WASI {
     this[kInstance] = undefined;
   }
 
-  setupInstance(instance, memory) {
+  finalizeBindings(instance, {
+    memory = instance.exports.memory
+  } = {}) {
+    if (this[kStarted]) {
+      throw new ERR_WASI_ALREADY_STARTED();
+    }
+
     validateObject(instance, 'instance');
     validateObject(instance.exports, 'instance.exports');
 
     if (memory != null) {
       if (!(memory instanceof WebAssembly.Memory)) {
-        throw new ERR_INVALID_ARG_TYPE('memory', 'WebAssembly.Memory', memory);
+        throw new ERR_INVALID_ARG_TYPE('options.memory', 'WebAssembly.Memory', memory);
       }
       this[kSetMemory](memory);
-    } else {
-      this[kSetMemory](instance.exports.memory);
     }
 
     this[kInstance] = instance;
@@ -133,11 +137,7 @@ class WASI {
 
   // Must not export _initialize, must export _start
   start(instance) {
-    if (this[kStarted]) {
-      throw new ERR_WASI_ALREADY_STARTED();
-    }
-
-    this.setupInstance(instance);
+    this.finalizeBindings(instance);
 
     const { _start, _initialize } = this[kInstance].exports;
 
@@ -157,11 +157,7 @@ class WASI {
 
   // Must not export _start, may optionally export _initialize
   initialize(instance) {
-    if (this[kStarted]) {
-      throw new ERR_WASI_ALREADY_STARTED();
-    }
-
-    this.setupInstance(instance);
+    this.finalizeBindings(instance);
 
     const { _start, _initialize } = this[kInstance].exports;