Skip to content

Commit 3e8d43d

Browse files
mscdexitaloacasas
authored andcommitted
http: add new functions to OutgoingMessage
PR-URL: #11562 Backport-of: #10805 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
1 parent fedf26b commit 3e8d43d

File tree

3 files changed

+140
-1
lines changed

3 files changed

+140
-1
lines changed

doc/api/http.md

+60
Original file line numberDiff line numberDiff line change
@@ -948,6 +948,66 @@ Example:
948948
var contentType = response.getHeader('content-type');
949949
```
950950

951+
### response.getHeaderNames()
952+
<!-- YAML
953+
added: REPLACEME
954+
-->
955+
956+
* Returns: {Array}
957+
958+
Returns an array containing the unique names of the current outgoing headers.
959+
All header names are lowercase.
960+
961+
Example:
962+
963+
```js
964+
response.setHeader('Foo', 'bar');
965+
response.setHeader('Set-Cookie', ['foo=bar', 'bar=baz']);
966+
967+
var headerNames = response.getHeaderNames();
968+
// headerNames === ['foo', 'set-cookie']
969+
```
970+
971+
### response.getHeaders()
972+
<!-- YAML
973+
added: REPLACEME
974+
-->
975+
976+
* Returns: {Object}
977+
978+
Returns a shallow copy of the current outgoing headers. Since a shallow copy
979+
is used, array values may be mutated without additional calls to various
980+
header-related http module methods. The keys of the returned object are the
981+
header names and the values are the respective header values. All header names
982+
are lowercase.
983+
984+
Example:
985+
986+
```js
987+
response.setHeader('Foo', 'bar');
988+
response.setHeader('Set-Cookie', ['foo=bar', 'bar=baz']);
989+
990+
var headers = response.getHeaders();
991+
// headers === { foo: 'bar', 'set-cookie': ['foo=bar', 'bar=baz'] }
992+
```
993+
994+
### response.hasHeader(name)
995+
<!-- YAML
996+
added: REPLACEME
997+
-->
998+
999+
* `name` {String}
1000+
* Returns: {Boolean}
1001+
1002+
Returns `true` if the header identified by `name` is currently set in the
1003+
outgoing headers. Note that the header name matching is case-insensitive.
1004+
1005+
Example:
1006+
1007+
```js
1008+
var hasContentType = response.hasHeader('content-type');
1009+
```
1010+
9511011
### response.headersSent
9521012
<!-- YAML
9531013
added: v0.9.3

lib/_http_outgoing.js

+35
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,10 @@ const automaticHeaders = {
3232
};
3333

3434

35+
// Used to store headers returned by getHeaders()
36+
function OutgoingHeaders() {}
37+
OutgoingHeaders.prototype = Object.create(null);
38+
3539
var dateCache;
3640
function utcDate() {
3741
if (!dateCache) {
@@ -392,6 +396,37 @@ OutgoingMessage.prototype.getHeader = function getHeader(name) {
392396
};
393397

394398

399+
// Returns an array of the names of the current outgoing headers.
400+
OutgoingMessage.prototype.getHeaderNames = function getHeaderNames() {
401+
return (this._headers ? Object.keys(this._headers) : []);
402+
};
403+
404+
405+
// Returns a shallow copy of the current outgoing headers.
406+
OutgoingMessage.prototype.getHeaders = function getHeaders() {
407+
const headers = this._headers;
408+
const ret = new OutgoingHeaders();
409+
if (headers) {
410+
const keys = Object.keys(headers);
411+
for (var i = 0; i < keys.length; ++i) {
412+
const key = keys[i];
413+
const val = headers[key];
414+
ret[key] = val;
415+
}
416+
}
417+
return ret;
418+
};
419+
420+
421+
OutgoingMessage.prototype.hasHeader = function hasHeader(name) {
422+
if (typeof name !== 'string') {
423+
throw new TypeError('"name" argument must be a string');
424+
}
425+
426+
return !!(this._headers && this._headers[name.toLowerCase()]);
427+
};
428+
429+
395430
OutgoingMessage.prototype.removeHeader = function removeHeader(name) {
396431
if (arguments.length < 1) {
397432
throw new Error('"name" argument is required for removeHeader(name)');

test/parallel/test-http-mutable-headers.js

+45-1
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,13 @@ const cookies = [
2121
const s = http.createServer(common.mustCall((req, res) => {
2222
switch (test) {
2323
case 'headers':
24+
// Check that header-related functions work before setting any headers
25+
// eslint-disable-next-line no-restricted-properties
26+
assert.deepEqual(res.getHeaders(), {});
27+
assert.deepStrictEqual(res.getHeaderNames(), []);
28+
assert.deepStrictEqual(res.hasHeader('Connection'), false);
29+
assert.deepStrictEqual(res.getHeader('Connection'), undefined);
30+
2431
assert.throws(() => {
2532
res.setHeader();
2633
}, /^TypeError: Header name must be a valid HTTP Token \["undefined"\]$/);
@@ -34,15 +41,52 @@ const s = http.createServer(common.mustCall((req, res) => {
3441
res.removeHeader();
3542
}, /^Error: "name" argument is required for removeHeader\(name\)$/);
3643

44+
const arrayValues = [1, 2, 3];
3745
res.setHeader('x-test-header', 'testing');
3846
res.setHeader('X-TEST-HEADER2', 'testing');
3947
res.setHeader('set-cookie', cookies);
40-
res.setHeader('x-test-array-header', [1, 2, 3]);
48+
res.setHeader('x-test-array-header', arrayValues);
4149

4250
assert.strictEqual(res.getHeader('x-test-header'), 'testing');
4351
assert.strictEqual(res.getHeader('x-test-header2'), 'testing');
4452

53+
const headersCopy = res.getHeaders();
54+
// eslint-disable-next-line no-restricted-properties
55+
assert.deepEqual(headersCopy, {
56+
'x-test-header': 'testing',
57+
'x-test-header2': 'testing',
58+
'set-cookie': cookies,
59+
'x-test-array-header': arrayValues
60+
});
61+
// eslint-disable-next-line no-restricted-properties
62+
assert.deepEqual(headersCopy['set-cookie'], cookies);
63+
assert.strictEqual(headersCopy['x-test-array-header'], arrayValues);
64+
65+
assert.deepStrictEqual(res.getHeaderNames(),
66+
['x-test-header', 'x-test-header2',
67+
'set-cookie', 'x-test-array-header']);
68+
69+
assert.strictEqual(res.hasHeader('x-test-header2'), true);
70+
assert.strictEqual(res.hasHeader('X-TEST-HEADER2'), true);
71+
assert.strictEqual(res.hasHeader('X-Test-Header2'), true);
72+
assert.throws(() => {
73+
res.hasHeader();
74+
}, /^TypeError: "name" argument must be a string$/);
75+
assert.throws(() => {
76+
res.hasHeader(null);
77+
}, /^TypeError: "name" argument must be a string$/);
78+
assert.throws(() => {
79+
res.hasHeader(true);
80+
}, /^TypeError: "name" argument must be a string$/);
81+
assert.throws(() => {
82+
res.hasHeader({ toString: () => 'X-TEST-HEADER2' });
83+
}, /^TypeError: "name" argument must be a string$/);
84+
4585
res.removeHeader('x-test-header2');
86+
87+
assert.strictEqual(res.hasHeader('x-test-header2'), false);
88+
assert.strictEqual(res.hasHeader('X-TEST-HEADER2'), false);
89+
assert.strictEqual(res.hasHeader('X-Test-Header2'), false);
4690
break;
4791

4892
case 'contentLength':

0 commit comments

Comments
 (0)