From 3c8782f70e659e0a7bd5dc71b30cfbeda0d2c664 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Mon, 22 Nov 2021 09:59:13 +0100 Subject: [PATCH] deps: silence V8's warning on CompileFunction We are not ready to migrate yet. Refs: https://github.com/nodejs/node-v8/issues/214 PR-URL: https://github.com/nodejs/node/pull/40907 Reviewed-By: Jiawen Geng Reviewed-By: Colin Ihrig Reviewed-By: Rich Trott --- common.gypi | 2 +- deps/v8/include/v8-script.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/common.gypi b/common.gypi index 005503b6a89e03..c8d6bd78be2239 100644 --- a/common.gypi +++ b/common.gypi @@ -36,7 +36,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.8', + 'v8_embedder_string': '-node.9', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/include/v8-script.h b/deps/v8/include/v8-script.h index 1304a43325df46..770c796396149a 100644 --- a/deps/v8/include/v8-script.h +++ b/deps/v8/include/v8-script.h @@ -692,7 +692,6 @@ class V8_EXPORT ScriptCompiler { * It is possible to specify multiple context extensions (obj in the above * example). */ - V8_DEPRECATE_SOON("Use CompileFunction") static V8_WARN_UNUSED_RESULT MaybeLocal CompileFunctionInContext( Local context, Source* source, size_t arguments_count, Local arguments[], size_t context_extension_count,