Skip to content

Commit 3c8782f

Browse files
committed
deps: silence V8's warning on CompileFunction
We are not ready to migrate yet. Refs: nodejs/node-v8#214 PR-URL: #40907 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 80c5a65 commit 3c8782f

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.8',
39+
'v8_embedder_string': '-node.9',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/include/v8-script.h

-1
Original file line numberDiff line numberDiff line change
@@ -692,7 +692,6 @@ class V8_EXPORT ScriptCompiler {
692692
* It is possible to specify multiple context extensions (obj in the above
693693
* example).
694694
*/
695-
V8_DEPRECATE_SOON("Use CompileFunction")
696695
static V8_WARN_UNUSED_RESULT MaybeLocal<Function> CompileFunctionInContext(
697696
Local<Context> context, Source* source, size_t arguments_count,
698697
Local<String> arguments[], size_t context_extension_count,

0 commit comments

Comments
 (0)