Serialize 'expected' and 'actual' in isolation with regards to already seen values

malthe · malthe · commit 3aa6316946a9 · 2024-02-23T14:49:48.000+01:00
diff --git a/lib/internal/test_runner/reporter/tap.js b/lib/internal/test_runner/reporter/tap.js
@@ -224,8 +224,8 @@ function jsToYaml(indent, name, value, seen) {
     }
 
     if (errIsAssertion) {
-      result += jsToYaml(indent, 'expected', errExpected, seen);
-      result += jsToYaml(indent, 'actual', errActual, seen);
+      result += jsToYaml(indent, 'expected', errExpected, new SafeSet(seen));
+      result += jsToYaml(indent, 'actual', errActual, new SafeSet(seen));
       if (errOperator) {
         result += jsToYaml(indent, 'operator', errOperator, seen);
       }

Original file line number	Diff line number	Diff line change
`@@ -224,8 +224,8 @@ function jsToYaml(indent, name, value, seen) {`
`224`	`224`	`}`
`225`	`225`
`226`	`226`	`if (errIsAssertion) {`
`227`		`- result += jsToYaml(indent, 'expected', errExpected, seen);`
`228`		`- result += jsToYaml(indent, 'actual', errActual, seen);`
	`227`	`+ result += jsToYaml(indent, 'expected', errExpected, new SafeSet(seen));`
	`228`	`+ result += jsToYaml(indent, 'actual', errActual, new SafeSet(seen));`
`229`	`229`	`if (errOperator) {`
`230`	`230`	`result += jsToYaml(indent, 'operator', errOperator, seen);`
`231`	`231`	`}`