Skip to content

Commit 39c86bb

Browse files
Gioyikcodebytere
authored andcommitted
tools: replace deprecated iteritems() for items()
This is a Built-In change in Python 3 used by compile_commands_json.py to generate compile_commands_json.json. Node.js dropped Python 2 support in this script, `items()` works as expected replacement. PR-URL: #31528 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
1 parent eb3c6e9 commit 39c86bb

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

tools/gyp/pylib/gyp/generator/compile_commands_json.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ def CalculateVariables(default_variables, params):
4343

4444
def AddCommandsForTarget(cwd, target, params, per_config_commands):
4545
output_dir = params['generator_flags']['output_dir']
46-
for configuration_name, configuration in target['configurations'].iteritems():
46+
for configuration_name, configuration in target['configurations'].items():
4747
builddir_name = os.path.join(output_dir, configuration_name)
4848

4949
if IsMac(params):
@@ -92,7 +92,7 @@ def resolve(filename):
9292

9393
def GenerateOutput(target_list, target_dicts, data, params):
9494
per_config_commands = {}
95-
for qualified_target, target in target_dicts.iteritems():
95+
for qualified_target, target in target_dicts.items():
9696
build_file, target_name, toolset = (
9797
gyp.common.ParseQualifiedTarget(qualified_target))
9898
if IsMac(params):
@@ -102,7 +102,7 @@ def GenerateOutput(target_list, target_dicts, data, params):
102102
AddCommandsForTarget(cwd, target, params, per_config_commands)
103103

104104
output_dir = params['generator_flags']['output_dir']
105-
for configuration_name, commands in per_config_commands.iteritems():
105+
for configuration_name, commands in per_config_commands.items():
106106
filename = os.path.join(output_dir,
107107
configuration_name,
108108
'compile_commands.json')

0 commit comments

Comments
 (0)