Skip to content

Commit

Permalink
tools: Use throw new Error() consistently
Browse files Browse the repository at this point in the history
In preparation for a lint rule that will enforce `throw new Error()`
over `throw Error()`, fix the handful of instances in the code that
use `throw Error()`.

PR-URL: #3714
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
Trott authored and Fishrock123 committed Nov 11, 2015
1 parent 02e012e commit 38bb0d8
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions test/addons/make-callback/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ assert.strictEqual(42, makeCallback(recv, 'two', 1337));
const target = vm.runInNewContext(`
(function($Object) {
if (Object === $Object)
throw Error('bad');
throw new Error('bad');
return Object;
})
`);
Expand All @@ -55,7 +55,7 @@ const forward = vm.runInNewContext(`
// Runs in outer context.
const endpoint = function($Object) {
if (Object === $Object)
throw Error('bad');
throw new Error('bad');
return Object;
};
assert.strictEqual(Object, makeCallback(process, forward, endpoint));
2 changes: 1 addition & 1 deletion test/parallel/test-assert.js
Original file line number Diff line number Diff line change
Expand Up @@ -465,6 +465,6 @@ testBlockTypeError(assert.doesNotThrow, undefined);

// https://github.com/nodejs/node/issues/3275
assert.throws(() => { throw 'error'; }, err => err === 'error');
assert.throws(() => { throw Error(); }, err => err instanceof Error);
assert.throws(() => { throw new Error(); }, err => err instanceof Error);

console.log('All OK');
2 changes: 1 addition & 1 deletion test/parallel/test-http-mutable-headers.js
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ function nextTest() {
break;

default:
throw Error('?');
throw new Error('?');
}

response.setEncoding('utf8');
Expand Down
2 changes: 1 addition & 1 deletion test/pummel/test-regress-GH-814.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ var timeToQuit = Date.now() + 8e3; //Test during no more than this seconds.
}
}
else {
throw Error("Buffer GC'ed test -> FAIL");
throw new Error("Buffer GC'ed test -> FAIL");
}

if (Date.now() < timeToQuit) {
Expand Down
2 changes: 1 addition & 1 deletion test/pummel/test-regress-GH-814_2.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ function tailCB(data) {
console.error('[FAIL]\n DATA -> ');
console.error(data);
console.error('\n');
throw Error('Buffers GC test -> FAIL');
throw new Error('Buffers GC test -> FAIL');
}
}

Expand Down

0 comments on commit 38bb0d8

Please sign in to comment.