Skip to content

Commit

Permalink
test: update postmortem metadata test for V8 7.1
Browse files Browse the repository at this point in the history
The V8 7.1 update requires the following adjustments to the
postmortem debugging metadata constants:

- v8dbg_class_JSArrayBuffer__byte_length__Object
  Use: v8dbg_class_JSArrayBuffer__byte_length__size_t

- v8dbg_class_JSArrayBufferView__raw_byte_length__Object
  Use: v8dbg_class_JSArrayBufferView__byte_length__size_t

- v8dbg_class_JSArrayBufferView__raw_byte_offset__Object
  Use: v8dbg_class_JSArrayBufferView__byte_offset__size_t

- v8dbg_class_String__length__SMI
  Use: v8dbg_class_String__length__int32_t

Refs: v8/v8@5cfe1a6
Refs: v8/v8@c7a0049

PR-URL: #23423
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
  • Loading branch information
cjihrig authored and targos committed Dec 6, 2018
1 parent 3d6d974 commit 379bf1a
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test/v8-updates/test-postmortem-metadata.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,10 @@ function getExpectedSymbols() {
'v8dbg_class_HeapObject__map__Map',
'v8dbg_class_JSArray__length__Object',
'v8dbg_class_JSArrayBuffer__backing_store__Object',
'v8dbg_class_JSArrayBuffer__byte_length__Object',
'v8dbg_class_JSArrayBuffer__byte_length__size_t',
'v8dbg_class_JSArrayBufferView__buffer__Object',
'v8dbg_class_JSArrayBufferView__raw_byte_length__Object',
'v8dbg_class_JSArrayBufferView__raw_byte_offset__Object',
'v8dbg_class_JSArrayBufferView__byte_length__size_t',
'v8dbg_class_JSArrayBufferView__byte_offset__size_t',
'v8dbg_class_JSDate__value__Object',
'v8dbg_class_JSFunction__context__Context',
'v8dbg_class_JSFunction__shared__SharedFunctionInfo',
Expand Down Expand Up @@ -103,7 +103,7 @@ function getExpectedSymbols() {
'v8dbg_class_UncompiledData__start_position__int32_t',
'v8dbg_class_SlicedString__offset__SMI',
'v8dbg_class_SlicedString__parent__String',
'v8dbg_class_String__length__SMI',
'v8dbg_class_String__length__int32_t',
'v8dbg_class_ThinString__actual__String',
'v8dbg_context_idx_scope_info',
'v8dbg_context_idx_prev',
Expand Down

0 comments on commit 379bf1a

Please sign in to comment.