Skip to content

Commit

Permalink
test: lint fixes for ESLint update
Browse files Browse the repository at this point in the history
This commit introduces changes required for the ESLint 5 update.

PR-URL: #20855
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
cjihrig authored and targos committed Jun 24, 2018
1 parent bfac7be commit 357eaf3
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
1 change: 1 addition & 0 deletions test/es-module/test-esm-forbidden-globals.mjs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Flags: --experimental-modules
import '../common';

// eslint-disable-next-line no-undef
if (typeof arguments !== 'undefined') {
throw new Error('not an ESM');
}
Expand Down
3 changes: 2 additions & 1 deletion test/parallel/test-console-is-a-namespace.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ require('../common');
const { test, assert_equals, assert_true, assert_false } =
require('../common/wpt');

global.console = global.console; // Should not throw.
// Assigning to itself should not throw.
global.console = global.console; // eslint-disable-line no-self-assign

const self = global;

Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-http2-socket-proxy.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ server.on('stream', common.mustCall(function(stream, headers) {
common.expectsError(() => (socket.write = undefined), errMsg);

// Resetting the socket listeners to their own value should not throw.
socket.on = socket.on;
socket.once = socket.once;
socket.on = socket.on; // eslint-disable-line no-self-assign
socket.once = socket.once; // eslint-disable-line no-self-assign

stream.respond();

Expand Down

0 comments on commit 357eaf3

Please sign in to comment.