url: export URLSearchParams

Fixes: #10761
nodejs · Jan 22, 2017 · 326e967 · 326e967 · targos · Jan 23, 2017
1 parent 4f8582e
commit 326e967
Show file tree

Hide file tree

Showing 11 changed files with 24 additions and 57 deletions.
diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -1045,6 +1045,7 @@ function urlToOptions(url) {
 }
 
 exports.URL = URL;
+exports.URLSearchParams = URLSearchParams;
 exports.originFor = originFor;
 exports.domainToASCII = domainToASCII;
 exports.domainToUnicode = domainToUnicode;

diff --git a/lib/url.js b/lib/url.js
@@ -17,6 +17,7 @@ exports.resolve = urlResolve;
 exports.resolveObject = urlResolveObject;
 exports.format = urlFormat;
 exports.URL = internalUrl.URL;
+exports.URLSearchParams = internalUrl.URLSearchParams;
 exports.originFor = internalUrl.originFor;
 exports.domainToASCII = internalUrl.domainToASCII;
 exports.domainToUnicode = internalUrl.domainToUnicode;

diff --git a/test/parallel/test-whatwg-url-searchparams-append.js b/test/parallel/test-whatwg-url-searchparams-append.js
@@ -2,13 +2,9 @@
 
 require('../common');
 const assert = require('assert');
-const URL = require('url').URL;
+const URLSearchParams = require('url').URLSearchParams;
 
-const m = new URL('http://example.org');
-let params = m.searchParams;
-
-// Until we export URLSearchParams
-const URLSearchParams = params.constructor;
+let params;
 
 // Append same name
 params = new URLSearchParams();

diff --git a/test/parallel/test-whatwg-url-searchparams-constructor.js b/test/parallel/test-whatwg-url-searchparams-constructor.js
@@ -2,13 +2,9 @@
 
 require('../common');
 const assert = require('assert');
-const URL = require('url').URL;
+const URLSearchParams = require('url').URLSearchParams;
 
-const m = new URL('http://example.org');
-let params = m.searchParams;
-
-// Until we export URLSearchParams
-const URLSearchParams = params.constructor;
+let params;
 
 // Basic URLSearchParams construction
 params = new URLSearchParams();

diff --git a/test/parallel/test-whatwg-url-searchparams-delete.js b/test/parallel/test-whatwg-url-searchparams-delete.js
@@ -2,13 +2,11 @@
 
 require('../common');
 const assert = require('assert');
-const URL = require('url').URL;
+const url = require('url');
+const URL = url.URL;
+const URLSearchParams = url.URLSearchParams;
 
-const m = new URL('http://example.org');
-let params = m.searchParams;
-
-// Until we export URLSearchParams
-const URLSearchParams = params.constructor;
+let params;
 
 // Delete basics
 params = new URLSearchParams('a=b&c=d');

diff --git a/test/parallel/test-whatwg-url-searchparams-foreach.js b/test/parallel/test-whatwg-url-searchparams-foreach.js
@@ -2,18 +2,14 @@
 
 require('../common');
 const assert = require('assert');
-const URL = require('url').URL;
-
-const m = new URL('http://example.org');
-let params = m.searchParams;
-
-// Until we export URLSearchParams
-const URLSearchParams = params.constructor;
+const url = require('url');
+const URL = url.URL;
+const URLSearchParams = url.URLSearchParams;
 
 let a, b, i;
 
 // ForEach Check
-params = new URLSearchParams('a=1&b=2&c=3');
+const params = new URLSearchParams('a=1&b=2&c=3');
 const keys = [];
 const values = [];
 params.forEach(function(value, key) {

diff --git a/test/parallel/test-whatwg-url-searchparams-get.js b/test/parallel/test-whatwg-url-searchparams-get.js
@@ -2,13 +2,9 @@
 
 require('../common');
 const assert = require('assert');
-const URL = require('url').URL;
+const URLSearchParams = require('url').URLSearchParams;
 
-const m = new URL('http://example.org');
-let params = m.searchParams;
-
-// Until we export URLSearchParams
-const URLSearchParams = params.constructor;
+let params;
 
 // Get basics
 params = new URLSearchParams('a=b&c=d');

diff --git a/test/parallel/test-whatwg-url-searchparams-getall.js b/test/parallel/test-whatwg-url-searchparams-getall.js
@@ -2,14 +2,9 @@
 
 require('../common');
 const assert = require('assert');
-const URL = require('url').URL;
-
-const m = new URL('http://example.org');
-let params = m.searchParams;
-
-// Until we export URLSearchParams
-const URLSearchParams = params.constructor;
+const URLSearchParams = require('url').URLSearchParams;
 
+let params;
 let matches;
 
 // getAll() basics

diff --git a/test/parallel/test-whatwg-url-searchparams-has.js b/test/parallel/test-whatwg-url-searchparams-has.js
@@ -2,13 +2,9 @@
 
 require('../common');
 const assert = require('assert');
-const URL = require('url').URL;
+const URLSearchParams = require('url').URLSearchParams;
 
-const m = new URL('http://example.org');
-let params = m.searchParams;
-
-// Until we export URLSearchParams
-const URLSearchParams = params.constructor;
+let params;
 
 // Has basics
 params = new URLSearchParams('a=b&c=d');

diff --git a/test/parallel/test-whatwg-url-searchparams-set.js b/test/parallel/test-whatwg-url-searchparams-set.js
@@ -2,13 +2,9 @@
 
 require('../common');
 const assert = require('assert');
-const URL = require('url').URL;
+const URLSearchParams = require('url').URLSearchParams;
 
-const m = new URL('http://example.org');
-let params = m.searchParams;
-
-// Until we export URLSearchParams
-const URLSearchParams = params.constructor;
+let params;
 
 // Set basics
 params = new URLSearchParams('a=b&c=d');

diff --git a/test/parallel/test-whatwg-url-searchparams-stringifier.js b/test/parallel/test-whatwg-url-searchparams-stringifier.js
@@ -2,13 +2,9 @@
 
 require('../common');
 const assert = require('assert');
-const URL = require('url').URL;
+const URLSearchParams = require('url').URLSearchParams;
 
-const m = new URL('http://example.org');
-let params = m.searchParams;
-
-// Until we export URLSearchParams
-const URLSearchParams = params.constructor;
+let params;
 
 // Serialize space
 // querystring does not currently handle spaces intelligently