Skip to content

Commit 3236944

Browse files
devsnekgibfahn
authored andcommitted
util: fix negative 0 check in inspect
PR-URL: #17507 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent 19aa3b1 commit 3236944

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

lib/util.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -617,10 +617,8 @@ function formatValue(ctx, value, recurseTimes, ln) {
617617
}
618618

619619
function formatNumber(fn, value) {
620-
// Format -0 as '-0'. A `value === -0` check won't distinguish 0 from -0.
621-
// Using a division check is currently faster than `Object.is(value, -0)`
622-
// as of V8 6.1.
623-
if (1 / value === -Infinity)
620+
// Format -0 as '-0'. Checking `value === -0` won't distinguish 0 from -0.
621+
if (Object.is(value, -0))
624622
return fn('-0', 'number');
625623
return fn(`${value}`, 'number');
626624
}

test/parallel/test-util-inspect.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -405,6 +405,8 @@ assert.strictEqual(
405405
// test positive/negative zero
406406
assert.strictEqual(util.inspect(0), '0');
407407
assert.strictEqual(util.inspect(-0), '-0');
408+
// edge case from check
409+
assert.strictEqual(util.inspect(-5e-324), '-5e-324');
408410

409411
// test for sparse array
410412
{

0 commit comments

Comments
 (0)