Skip to content

Commit 3177b99

Browse files
kunalspathakTrott
authored andcommitted
src: fix build break for !NODE_USE_V8_PLATFORM
`StartInspector` should return `bool` but there was signature mismatch if not building for v8 platform i.e. `!NODE_USE_V8_PLATFORM` PR-URL: #8114 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
1 parent 4b883a3 commit 3177b99

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/node.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,8 +220,9 @@ static struct {
220220
void Initialize(int thread_pool_size) {}
221221
void PumpMessageLoop(Isolate* isolate) {}
222222
void Dispose() {}
223-
void StartInspector(Environment *env, int port, bool wait) {
223+
bool StartInspector(Environment *env, int port, bool wait) {
224224
env->ThrowError("Node compiled with NODE_USE_V8_PLATFORM=0");
225+
return false; // make compiler happy
225226
}
226227
#endif // !NODE_USE_V8_PLATFORM
227228
} v8_platform;

0 commit comments

Comments
 (0)