Skip to content

Commit

Permalink
test: revise pull request guide text about code
Browse files Browse the repository at this point in the history
Fixes: #45502
PR-URL: #45519
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
  • Loading branch information
Trott authored and danielleadams committed Jan 3, 2023
1 parent fbfd26d commit 305d4de
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions doc/contributing/pull-requests.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,13 +107,13 @@ git checkout -b my-branch -t upstream/HEAD

### Step 3: Code

The vast majority of pull requests opened against the `nodejs/node`
repository includes changes to one or more of the following:
Pull requests in Node.js typically involve changes to
one or more of a few places in the repository.

* the C/C++ code contained in the `src` directory
* the JavaScript code contained in the `lib` directory
* the documentation in `doc/api`
* tests within the `test` directory.
* C/C++ code contained in the `src` directory
* JavaScript code contained in the `lib` directory
* Documentation in `doc/api`
* Tests within the `test` directory

If you are modifying code, please be sure to run `make lint` (or
`vcbuild.bat lint` on Windows) to ensure that the changes follow the Node.js
Expand Down

0 comments on commit 305d4de

Please sign in to comment.