src: remove dead code in AddFingerprintDigest

tniessen · danielleadams · commit 30264490093d · 2022-04-23T22:47:09.000-04:00
This function is never called with md_size == 0, and it would make no sense to do so in the future either. PR-URL: #42145 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
diff --git a/src/crypto/crypto_common.cc b/src/crypto/crypto_common.cc
@@ -427,11 +427,8 @@ void AddFingerprintDigest(
     fingerprint[(3*i)+2] = ':';
   }
 
-  if (md_size > 0) {
-    fingerprint[(3*(md_size-1))+2] = '\0';
-  } else {
-    fingerprint[0] = '\0';
-  }
+  DCHECK_GT(md_size, 0);
+  fingerprint[(3 * (md_size - 1)) + 2] = '\0';
 }
 
 template <const char* (*nid2string)(int nid)>

Original file line number	Diff line number	Diff line change
`@@ -427,11 +427,8 @@ void AddFingerprintDigest(`
`427`	`427`	`fingerprint[(3*i)+2] = ':';`
`428`	`428`	`}`
`429`	`429`
`430`		`- if (md_size > 0) {`
`431`		`- fingerprint[(3*(md_size-1))+2] = '\0';`
`432`		`- } else {`
`433`		`- fingerprint[0] = '\0';`
`434`		`- }`
	`430`	`+ DCHECK_GT(md_size, 0);`
	`431`	`+ fingerprint[(3 * (md_size - 1)) + 2] = '\0';`
`435`	`432`	`}`
`436`	`433`
`437`	`434`	`template <const char* (*nid2string)(int nid)>`