From 2da6f622dc32ea4bacbf67d2acbc09d9359c27e7 Mon Sep 17 00:00:00 2001
From: Anna Henningsen <anna@addaleax.net>
Date: Sun, 30 Sep 2018 12:08:30 -0400
Subject: [PATCH] src: deprecate `UVException()` without `Isolate*`
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This method, like all other methods which use `Isolate::GetCurrent()`,
should be avoided.

This was probably overlooked in 75adde07f9a2de7f38a.

PR-URL: https://github.com/nodejs/node/pull/23175
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
---
 src/node.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/node.h b/src/node.h
index 75570a15afd153..bb2a9d2e0533ac 100644
--- a/src/node.h
+++ b/src/node.h
@@ -139,7 +139,8 @@ NODE_DEPRECATED("Use ErrnoException(isolate, ...)",
                         path);
 })
 
-inline v8::Local<v8::Value> UVException(int errorno,
+NODE_DEPRECATED("Use UVException(isolate, ...)",
+                inline v8::Local<v8::Value> UVException(int errorno,
                                         const char* syscall = nullptr,
                                         const char* message = nullptr,
                                         const char* path = nullptr) {
@@ -148,7 +149,7 @@ inline v8::Local<v8::Value> UVException(int errorno,
                      syscall,
                      message,
                      path);
-}
+})
 
 /*
  * These methods need to be called in a HandleScope.