Skip to content

Commit 2d9e9cc

Browse files
committed
fixup! fixup! fs: pass correct path to DirentFromStats during glob
1 parent c09392d commit 2d9e9cc

File tree

1 file changed

+6
-12
lines changed

1 file changed

+6
-12
lines changed

test/parallel/test-fs-glob.mjs

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -338,6 +338,9 @@ describe('fsPromises glob', function() {
338338
}
339339
});
340340

341+
const normalizeDirent = (dirent) => relative(fixtureDir, join(dirent.parentPath, dirent.name));
342+
const normalizePath = (path) => (isAbsolute(path) ? relative(fixtureDir, path) : join(path));
343+
341344
describe('glob - withFileTypes', function() {
342345
const promisified = promisify(glob);
343346
for (const [pattern, expected] of Object.entries(patterns)) {
@@ -348,10 +351,7 @@ describe('glob - withFileTypes', function() {
348351
exclude: (dirent) => assert.ok(dirent instanceof Dirent),
349352
});
350353
assertDirents(actual);
351-
assert.deepStrictEqual(
352-
actual.map((dirent) => relative(fixtureDir, join(dirent.parentPath, dirent.name))).sort(),
353-
expected.map((path) => (isAbsolute(path) ? relative(fixtureDir, path) : path)).sort()
354-
);
354+
assert.deepStrictEqual(actual.map(normalizeDirent).sort(), expected.map(normalizePath).sort());
355355
});
356356
}
357357
});
@@ -365,10 +365,7 @@ describe('globSync - withFileTypes', function() {
365365
exclude: (dirent) => assert.ok(dirent instanceof Dirent),
366366
});
367367
assertDirents(actual);
368-
assert.deepStrictEqual(
369-
actual.map((dirent) => relative(fixtureDir, join(dirent.parentPath, dirent.name))).sort(),
370-
expected.map((path) => (isAbsolute(path) ? relative(fixtureDir, path) : path)).sort()
371-
);
368+
assert.deepStrictEqual(actual.map(normalizeDirent).sort(), expected.map(normalizePath).sort());
372369
});
373370
}
374371
});
@@ -383,10 +380,7 @@ describe('fsPromises glob - withFileTypes', function() {
383380
exclude: (dirent) => assert.ok(dirent instanceof Dirent),
384381
})) actual.push(item);
385382
assertDirents(actual);
386-
assert.deepStrictEqual(
387-
actual.map((dirent) => relative(fixtureDir, join(dirent.parentPath, dirent.name))).sort(),
388-
expected.map((path) => (isAbsolute(path) ? relative(fixtureDir, path) : path)).sort()
389-
);
383+
assert.deepStrictEqual(actual.map(normalizeDirent).sort(), expected.map(normalizePath).sort());
390384
});
391385
}
392386
});

0 commit comments

Comments
 (0)